New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740571 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Grey favicon during fade-in animation of ContentSuggestions

Project Member Reported by gambard@chromium.org, Jul 10 2017 
What steps will reproduce the problem?
(1) Open a new tab

What is the expected result?
The Most Visited tiles should have the favicon displayed

What happens instead?
The tiles have a grey background.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206

commit c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206
Author: gambard <gambard@chromium.org>
Date: Thu Jul 13 09:57:38 2017

Use a favicon cache in ContentSuggestions

Using a cache for the favicon allows a synchronous callback for the
favicon fetch, allowing it to present a favicon during the fade-in
animation of the NTP.

Bug:  740571 
Change-Id: Id387491ab977f6e39847ce0a6c03ad997682a4ee
Reviewed-on: https://chromium-review.googlesource.com/568149
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486330}
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.h
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.mm
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/ui/favicon/BUILD.gn
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/ui/favicon/favicon_attributes_provider.h
[modify] https://crrev.com/c593f6ad3ceb7b54a7eebc22ee8d15ba6aeaf206/ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm

Comment 2 by gambard@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment