New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740569 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Add footer informations in ContentSuggestions

Project Member Reported by gambard@chromium.org, Jul 10 2017

Issue description

ContentSuggestions should be displaying "BEGIN_LINKLearn moreEND_LINK about suggested content" at the bottom of the collection.
 

Comment 1 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29a4533b9701503e0b81af8300dcbd2bad05e540

commit 29a4533b9701503e0b81af8300dcbd2bad05e540
Author: gambard <gambard@chromium.org>
Date: Mon Jul 24 16:18:26 2017

Add link to help center at the bottom of ContentSuggestions

This CL adds a cell at the bottom of the ContentSuggestions collection,
containing a text informing the user that more information are
available in the help center, with a link to it.

Bug:  740569 
Change-Id: I4dd3655d056cf15f57195434f2be565ad8c7df1e
Reviewed-on: https://chromium-review.googlesource.com/570169
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488993}
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/content_suggestions/mediator_util.h
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/content_suggestions/mediator_util.mm
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.h
[add] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[add] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item_unittest.mm
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h
[modify] https://crrev.com/29a4533b9701503e0b81af8300dcbd2bad05e540/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a927e4ef7630232a44128fa55467947fe73bf9be

commit a927e4ef7630232a44128fa55467947fe73bf9be
Author: gambard <gambard@chromium.org>
Date: Tue Jul 25 09:06:01 2017

Open the help center when Learn More is tapped

Bug:  740569 
Change-Id: I3511d441e0b5ccb86e821f99e2606d43e538eda5
Reviewed-on: https://chromium-review.googlesource.com/583654
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489260}
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.h
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_learn_more_item.mm
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/showcase/content_suggestions/BUILD.gn
[modify] https://crrev.com/a927e4ef7630232a44128fa55467947fe73bf9be/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in latest build 62.0.3173.0 in iPhone7(iOS 10.3.3), iPhone6plus(iOS 11) and iPad Air(iOS 10.3.3)

The suggestion footer is displaying text 'Learn more about suggested content'

Link to screenshot: 
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8cklQNmw1RkZsOHM/view?usp=sharing

Sign in to add a comment