New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740565 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 740863



Sign in to add a comment

Lines displayed in ContentSuggestions

Project Member Reported by gambard@chromium.org, Jul 10 2017

Issue description

What steps will reproduce the problem?
(1) Open ContentSuggestions

What is the expected result?
The UI should be fine

What happens instead?
There are lines displayed below all elements without a background (Most Visited tiles, omnibox, headers...)

Filled: https://github.com/material-components/material-components-ios/issues/1406
 

Comment 1 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged
Blocking: 740863
Labels: -Pri-3 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8846e970a6ffcc6f3fc5fd554a3969b802899922

commit 8846e970a6ffcc6f3fc5fd554a3969b802899922
Author: gambard <gambard@chromium.org>
Date: Fri Aug 04 13:06:33 2017

Removes superfluous lines in ContentSuggestions

The separators of the cells and headers where displayed even if they
had no background.
This CL removes those lines.

Bug:  740565 
Change-Id: If6e2ab6225eec5e7cfc0112c8cff475530c479ed
Reviewed-on: https://chromium-review.googlesource.com/602228
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492004}
[modify] https://crrev.com/8846e970a6ffcc6f3fc5fd554a3969b802899922/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on latest chrome canary version 62.0.3179.0 on iPhones and iPads with iOS 10.3.3 and 11 beta 5.  No lines are displayed with content suggestions : on.  The NTP looks good without any line.

Sign in to add a comment