Tapping the ContentSuggestions omnibox does not work with card style |
||||
Issue descriptionWhen the ContentSuggestions are using the card style (iPad, iPhone landscape, iPhone x+), tapping the omnibox, before it is scrolled to the top, move the whole collection to the left instead of just moving the omnibox to the top What steps will reproduce the problem? (1) Have iPhone set up as landscape (2) Tap the fake omnibox in the NTP to pin it to the top (3) Unfocus the omnibox. What is the expected result? The omnibox should go to its previous position What happens instead? The whole collection is moved to the left. Everything is fine after scrolling a little.
,
Jul 21 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8b88f80d4523fce8e2111d80a94d7e9e0fba613 commit b8b88f80d4523fce8e2111d80a94d7e9e0fba613 Author: gambard <gambard@chromium.org> Date: Tue Jul 25 14:35:23 2017 Fix ContentSuggestions inset on iPad and landscape The size of the items displayed by the collection is not based on the inset of its section. It allows ContentSuggestions to display correctly on iPad and iPhone landscape by adjusting the inset for all sections. Bug: 740564 , 740563 Change-Id: I77edf2d01a45964a527b60e882d9a7eda97a0429 Reviewed-on: https://chromium-review.googlesource.com/584831 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#489288} [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Jul 25 2017
,
Aug 1 2017
Verified in 62.0.3173.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, Followed step #0 Omnibox goes to its previous position. |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Jul 10 2017