ContentSuggestions omnibox not taking all the width when scrolling |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Set the iPhone in landscape (2) Scroll down on the NTP, down to the point where the omnibox is sticked to the top What is the expected result? The omnibox should take the full width of the screen. What happens instead? The omnibox has the same width as the cards
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8b88f80d4523fce8e2111d80a94d7e9e0fba613 commit b8b88f80d4523fce8e2111d80a94d7e9e0fba613 Author: gambard <gambard@chromium.org> Date: Tue Jul 25 14:35:23 2017 Fix ContentSuggestions inset on iPad and landscape The size of the items displayed by the collection is not based on the inset of its section. It allows ContentSuggestions to display correctly on iPad and iPhone landscape by adjusting the inset for all sections. Bug: 740564 , 740563 Change-Id: I77edf2d01a45964a527b60e882d9a7eda97a0429 Reviewed-on: https://chromium-review.googlesource.com/584831 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#489288} [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/b8b88f80d4523fce8e2111d80a94d7e9e0fba613/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Jul 25 2017
,
Aug 1 2017
Tested in 62.0.3173.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, 1. Have device in portrait 2. Scroll to the 'Articles for you' 3. Change device mode to landscape Observed: Omnibox is not taking all the width of the screen https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLcHo5aEo5QTdScWc/view
,
Aug 2 2017
This is another bug tracked in crbug.com/750637 and which should be fixed in next Canary. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by fi...@chromium.org
, Jul 21 2017