Add monitoring on event_mon side that will guarantee that test locations are not reported multiple times too frequently |
||||
Issue description
This can probably be done with a query like this:
WITH
identical_report_counts AS (
SELECT
count(*) as num_reports
FROM
gfstmp_chrome_infra.tmp_chrome_infra.today as a
WHERE
a.(GWSLogEntryProto_weak_fields_pkg.PlayExtension).chromeinfra_event.has_test_locations_event
GROUP BY
a.(GWSLogEntryProto_weak_fields_pkg.PlayExtension).chromeinfra_event.test_locations_event.loctions.test_name,
a.(GWSLogEntryProto_weak_fields_pkg.PlayExtension).chromeinfra_event.test_locations_event.loctions.file,
a.(GWSLogEntryProto_weak_fields_pkg.PlayExtension).chromeinfra_event.test_locations_event.loctions.line
)
SELECT
MAX(num_reports)
FROM
identical_reports_counts;
and alert if the resulting value is too high.
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/78cd41e1104b3ca34cab54925dba35a1375a2982 commit 78cd41e1104b3ca34cab54925dba35a1375a2982 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Mon Jul 10 16:38:58 2017 Upload only new locations to event_mon This code uses old DB library to be consistent with the rest of the app. R=tandrii@chromium.org Bug: 710897, 740554 Change-Id: Idc0bc0882b14075272d57a74fc0020796119b355 Reviewed-on: https://chromium-review.googlesource.com/563621 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [add] https://crrev.com/78cd41e1104b3ca34cab54925dba35a1375a2982/appengine/test_results/appengine_module/test_results/model/testlocation.py [modify] https://crrev.com/78cd41e1104b3ca34cab54925dba35a1375a2982/appengine/test_results/appengine_module/test_results/handlers/monitoring.py [modify] https://crrev.com/78cd41e1104b3ca34cab54925dba35a1375a2982/appengine/test_results/appengine_module/test_results/handlers/test/monitoring_test.py
,
Aug 11 2017
CC Sean, who will be taking over flakiness effort as I'm transitioning to another team.
,
Aug 13
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted