Issue metadata
Sign in to add a comment
|
Test failures on windows webgl2_conformance_tests on V8 FYI bots |
||||||||||||||||||||||||
Issue descriptionSee: https://build.chromium.org/p/client.v8.fyi/builders/Win%20Release%20%28NVIDIA%29/builds/2016 Fails gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_bugs_angle_ambiguous_function_call Seems persistent, but didn't block the roll in CQ: https://chromium-review.googlesource.com/c/565298 The optional win gpu trybot ran without problem.
,
Jul 10 2017
We could. But how often does the revers happen? E.g. ToT angle breaking the bots while stable remains ok?
,
Jul 10 2017
Good question. To be honest I can think of at least one recent case where an intermittent crash was introduced on top-of-tree ANGLE and Yuly found and reverted it. So if the situation in this bug doesn't happen very often (and sorry for my oversight) I think it's safest to stick with the DEPS version of ANGEL.
,
Jul 10 2017
The crashes that I handled were on FYI bots which were not part of ANGLE CQ. I believe that v8 bots configurations are covered by ANGLE CQ, so ANGLE changes that may break them should fail to land. I'd recommend to go ahead with ToT ANGLE, and make sure that v8 configurations are indeed covered by ANGLE CQ. But, the scenario in this issue is pretty rare, and the existing config worked fine so far, so we may just keep it as is and fix the occasional bugs when they happen.
,
Jul 11 2017
I think v8 configuration == gpu fyi configuration (except angle version). So, if those broke by an angle ToT change, our bots would have broken too. I'll wait for a bit more data to make a decision. Happened only once so far. Now I'm aware of this case and tracking it down next time will be much easier. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Jul 10 2017Mergedinto: 731324
Owner: kbr@chromium.org
Status: Duplicate (was: Untriaged)