New issue
Advanced search Search tips

Issue 740542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

webdatabase uses inconsistent SQL headers

Project Member Reported by brat...@opera.com, Jul 10 2017

Issue description

Some of third_party/WebKit/Source/webdatabase uses sqlite with internals exposed and some uses it with internals not exposed. That mismatch causes issues in jumbo builds since it compiles several files together and need headers to say the same thing.

It's possible to workaround by either excluding webdatabase from jumbo compilations or by excluding one set of files so that the remaining files have consistent sqlite headers.

I plan to change so all webdatabase compile with the same exposed part of sqlite though.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a66d5965d7de67f6a22dca35c00b76cd1fb59a

commit 51a66d5965d7de67f6a22dca35c00b76cd1fb59a
Author: Daniel Bratell <bratell@opera.com>
Date: Tue Jul 11 08:35:18 2017

Use the same sqlite header configuration in all of webdatabase

Some of third_party/WebKit/Source/webdatabase uses sqlite withq
internals exposed and some uses it with internals not exposed. That
mismatch causes issues in jumbo builds since it compiles several files
together and need headers to say the same thing.

This changes webdatabase so that it all compile with the
CHROMIUM_SQLITE_INTERNALS define set.

R=michaeln@chromium.org

Bug:  740542 
Change-Id: I0b5c66fde7d191afd7a7143ef32c9c6f1b21b9e2
Reviewed-on: https://chromium-review.googlesource.com/565502
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#485558}
[modify] https://crrev.com/51a66d5965d7de67f6a22dca35c00b76cd1fb59a/third_party/WebKit/Source/modules/webdatabase/BUILD.gn
[modify] https://crrev.com/51a66d5965d7de67f6a22dca35c00b76cd1fb59a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
[modify] https://crrev.com/51a66d5965d7de67f6a22dca35c00b76cd1fb59a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.h
[modify] https://crrev.com/51a66d5965d7de67f6a22dca35c00b76cd1fb59a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
[modify] https://crrev.com/51a66d5965d7de67f6a22dca35c00b76cd1fb59a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

Comment 2 by brat...@opera.com, Jul 14 2017

Status: Fixed (was: Unconfirmed)

Sign in to add a comment