New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740530 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Fix alignment of favicon and publisher info

Project Member Reported by gambard@chromium.org, Jul 10 2017

Issue description

The favicon and the publisher info should have a better alignment: both should have the same top anchor.
 
Labels: hotlist-ContentSuggestions

Comment 2 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged
The two elements should be Y-centered.
The top alignment should still be fixed to have the center alignment even if the elements have different sizes.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c34ebdebc059faa1d7e4d936407bd759c00ec2

commit d3c34ebdebc059faa1d7e4d936407bd759c00ec2
Author: gambard <gambard@chromium.org>
Date: Tue Jul 25 12:38:02 2017

Change ContentSuggestions favicon top alignment

The additional information and the favicon should be able to be center
aligned, even if they don't have the same height.
For now it worked because they have the same height.

Bug:  740530 
Change-Id: Ib4e1acd022cb03635ba5fade1310fc2b2b01ad8d
Reviewed-on: https://chromium-review.googlesource.com/584587
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489280}
[modify] https://crrev.com/d3c34ebdebc059faa1d7e4d936407bd759c00ec2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 62.0.3173.0 canary, iPhone6 plus iOS 10.3.3, iPhone7 iOS11, iPad Pro iOS11

The favicon and the publisher info are left aligned.

https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLNGJYRE1mb1F2c0U/view
Looks good

Sign in to add a comment