Clicks on Doodle (and other NTP elements) shouldn't be AUTO_BOOKMARK |
||||||||
Issue descriptionChrome Version: M55 and above OS: Desktop What steps will reproduce the problem? (1) Clear browsing history (2) Open NTP (3) Click on "Mail" or Doodle What is the expected result? The click is ignored for the purpose of Most Visited tiles (eg. Top Sites). What happens instead? The click gets represented in history as AUTO_BOOKMARK and hence contributes to Top Sites. This is due to a buggy implementation https://codereview.chromium.org/2084953003.
,
Jul 21 2017
,
Jan 11 2018
,
Jan 11 2018
,
Jul 12
We'd like to tackle this as an ntp-starter-bug. What's a good place to get started? It looks like the AUTO_BOOKMARK for tiles are set in: https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?l=1583. Is there a known way to test for "IsTile" or "IsNotDoodle" / "IsNotOGBLink" here?
,
Jul 13
,
Jul 16
Yes, I think that's the place. I'm not sure how to differentiate those link clicks. Maybe it's possible to determine if it came from the MV iframe?
,
Sep 16
,
Oct 1
From what I have found out: https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?rcl=5e3bf2a1f618d292d253ee5b0236fcd2cb909c50&l=1595 This is the place where the navi transition type gets changed to AUTO_BOOKMARK for all the link clicked on the NTP. https://cs.chromium.org/chromium/src/content/browser/frame_host/navigator_impl.cc?rcl=5e3bf2a1f618d292d253ee5b0236fcd2cb909c50&l=464 This is the place where the OverrideNavigationParams gets called. However, when attempting to get the frame name from the render_frame_host, no matter which NTP element you click, they both return an empty frame name, and thus it is not that easy to differentiate the click originate from OGB or Doodle or MostVisited Tile.
,
Oct 10
Returning this to the queue as Weilun's shifted focus to Metrics. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by treib@chromium.org
, Jul 17 2017Components: UI>Browser>NewTabPage
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Assigned (was: Untriaged)