New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740513 link

Starred by 1 user
Status: Fixed
Owner:
█ yhong@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
marcochen@chromium.org
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Deprecate verify_components and verify_value by probe

Project Member Reported by hungte@chromium.org, Jul 10 2017 
Currently the verification of installed components is done by many tests in different ways, including:
 - verify_components (based on HWID)
 - verify_value (an arbitrary verification)
 - i2c_probe
 - ectool_i2c_dev_id
 - line_check_item

It's very inefficient to have multiple tests running in sequence just for probing components and made test list not portable.

I think our new probing language, with the general 'probe' test, should be able to replace all these functions.

Please try to take KBL system reference test list and remove replace all the probing type tests into probe.

Comment 1 by hungte@chromium.org, Jul 26 2017

Cc: -akahuang@chromium.org -pihsun@chromium.org chromeos-factory-eng@google.com

Comment 2 by hungte@chromium.org, Aug 22 2017 

add one: verify_touch_device_fw.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-soraka-private/+/7761241e6fb352623fee18fb05bb944e22bbe3ee

commit 7761241e6fb352623fee18fb05bb944e22bbe3ee
Author: Yong Hong <yhong@google.com>
Date: Tue Jan 09 13:49:38 2018
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/27e5d03938b1fd86d1c58e35326c023928b9a822

commit 27e5d03938b1fd86d1c58e35326c023928b9a822
Author: Yong Hong <yhong@chromium.org>
Date: Tue Feb 06 20:21:10 2018

hwid: Simplifies the `verifier` module.

This CL does two things:
  1. Remove ` VerifyComponent` function and its callers because this
     verification process is replaced by the probe framework.
  2. Simplify the unittest for the `verifier` module to only focus
     on the `veifier` module.

BUG= chromium:740513 
TEST=make test
CQ-DEPEND=CL:*540879

Change-Id: I7d246cc6e6101920dea816cee1f494bf3a24b039
Reviewed-on: https://chromium-review.googlesource.com/853657
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/test/test_lists/generic_common.test_list.json
[add] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/testdata/test_verifier_db.yaml
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/probe/probe_cmdline.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/po/zh-CN.po
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/test/test_lists/generic_smt.test_list.json
[delete] https://crrev.com/1534db75e584a728b06d6a063d36a1ac6d4e2446/py/test/pytests/verify_components_unittest.py
[delete] https://crrev.com/1534db75e584a728b06d6a063d36a1ac6d4e2446/py/test/pytests/probe/probe_smt.json
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/gooftool/commands.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/test/pytests/probe/probe.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/hwid_utils.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/verifier.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/testdata/TEST_PROJECT
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/hwid_cmdline.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/verifier_unittest.py
[modify] https://crrev.com/27e5d03938b1fd86d1c58e35326c023928b9a822/py/hwid/v3/hwid_utils_unittest.py
[delete] https://crrev.com/1534db75e584a728b06d6a063d36a1ac6d4e2446/py/test/pytests/verify_components.py

Comment 5 by marcochen@chromium.org, Feb 13 2018

Cc: marcochen@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-nami-private/+/509d268231cee8f769e35e1f2f08184564a07d1e

commit 509d268231cee8f769e35e1f2f08184564a07d1e
Author: chuntsen <chuntsen@google.com>
Date: Wed May 16 15:34:38 2018
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/287e0d68c92260be4cef11438a3867b03d2c341f

commit 287e0d68c92260be4cef11438a3867b03d2c341f
Author: Yong Hong <yhong@chromium.org>
Date: Fri May 18 05:21:10 2018

pytest: Remove `verify_value` and `verify_touch_device_fw` pytests.

This CL removes the pytests `verify_value` or `verify_touch_device_fw`
because both of them can be replaced by the new pytest `probe` with
specific probing statements.

BUG= chromium:740513 
CQ-DEPEND=CL:*608547
TEST=None

Change-Id: I53c7a294d45f2b13523c5c943c764e913a29cc82
Reviewed-on: https://chromium-review.googlesource.com/1011531
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/287e0d68c92260be4cef11438a3867b03d2c341f/po/zh-CN.po
[modify] https://crrev.com/287e0d68c92260be4cef11438a3867b03d2c341f/py/test/test_lists/generic_common.test_list.json
[delete] https://crrev.com/b146b48029461df92a9eb622432a8a99e49978e0/py/test/pytests/verify_value.py
[delete] https://crrev.com/b146b48029461df92a9eb622432a8a99e49978e0/py/test/pytests/verify_touch_device_fw.py
[delete] https://crrev.com/b146b48029461df92a9eb622432a8a99e49978e0/py/test/pytests/verify_value_unittest.py

Comment 8 by yhong@chromium.org, May 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment