Issue metadata
Sign in to add a comment
|
Regression: Unable to Add/Edit Persons after adding new person from top menu bar in Ubuntu 14.04 |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3153.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and add person from top menu bar (2)Now in newly added person click People option and observe "Edit" and "Add Person" options Expected: "Add/Edit" options should be seen enabled and should be able to add new person from menu bar. Actual: Instead unable to add person or edit it as those options are seen disabled. This is a regression issue broken in M61. Good Build: 61.0.3145.0 dev Bad Build: 61.0.3146.0 dev NOTE: We don't have menu bar for chrome in windows
,
Jul 10 2017
Able to reproduce the issue on Ubuntu 14.04 using chrome version 61.0.3153.0.
,
Jul 10 2017
You are probably looking for a change made after 483692 (known good), but no later than 483696 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/00dcdcaefbacf82529f73820318f6ae65c17e253..2c893bc7e6fc522b1cae1eb9b686effde5bc7eca Suspecting https://codereview.chromium.org/2939943004 from changelog @asvitkine: Please confirm the issue or help in re-assigning if it is not related to your change.
,
Jul 10 2017
It's possible the account manager code relied on the previous order of browser activation notifications. Will take a look.
,
Jul 10 2017
Confirmed that my CL is the cause. Looking at how to fix.
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f07dafb11c6d75007a97a393120c327934d10c7 commit 9f07dafb11c6d75007a97a393120c327934d10c7 Author: Alexei Svitkine <asvitkine@google.com> Date: Tue Jul 11 15:30:22 2017 Fix Linux menu bar item visibility after creating new profile. The underlying code relied on OnBrowserSetLastActive() getting called twice, which got fixed by crrev.com/483695, which broke this. This CL fixes the code to not rely on that, fixing this issue. Specifically, AvatarMenu::RebuildMenu() relies on having up to date info from ActiveBrowserChanged() call - but the order the two functions were called was inversed. BUG= 740500 TEST=On Linux, from top-level "People" menu, click "Add person". Then, open the "People" menu again and verify "Edit..." item is enabled. Change-Id: Ia1001defe073b91a94dca5b8f3533c42906ca526 Reviewed-on: https://chromium-review.googlesource.com/565343 Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#485633} [modify] https://crrev.com/9f07dafb11c6d75007a97a393120c327934d10c7/chrome/browser/profiles/avatar_menu.h [modify] https://crrev.com/9f07dafb11c6d75007a97a393120c327934d10c7/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
,
Jul 11 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Jul 10 2017526 KB
526 KB View Download
799 KB
799 KB View Download