New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740487 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Aug 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment of text is seen on Sign-in promo extension bubble.

Reported by abom...@etouch.net, Jul 10 2017 
Chrome Version: 61.0.3153.0 (Official Build) 4b9102f9588fb6cf639a6165fd4777658d5ade0d-refs/heads/master@{#485143}-32/64 bit
OS: Windows(7,8,10)

Test url: https://chrome.google.com/webstore/detail/tabby-cat/mefhakmgclhhfbdadeojlkbllmecialg/related?hl=en

What steps will reproduce the problem?
1 Launch chrome and navigate to above test url
2.Click on 'Add to chrome' button and observe 'Sign-in promo extension' bubble.

Actual: Misalignment of text is seen on Sign-in promo extension bubble.
Expected: Text should be properly aligned.

This is regression issue, broken in 'M 61' and below is manual bisect info:
Good build:61.0.3143.0
Bad build:61.0.3144.0

Note: Issue is not seen on Mac and Linux OS.
bubble.png
25.5 KB View Download

Comment 1 by jmukthavaram@chromium.org, Jul 10 2017

Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.5 using chrome latest Canary-61.0.3153.0.
Manual bisect info:
------------------
Good build: 61.0.3143.0 -Revision-482834
Bad build: 61.0.3144.0 -Revision-483234

Per revision bisect info:
-----------------------
You are probably looking for a change made after 482839 (known good), but no later than 482840 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/95e377e8e0851d2d5fa089036b0e24a1a75f89c6..257ee88f3a0e1b02da7814cbc37f693494bad6d3

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/257ee88f3a0e1b02da7814cbc37f693494bad6d3

Bsep@,Could you please take a look & reassign to the right owner if it is not related to your change.

Thanks..!!

Comment 2 by bsep@chromium.org, Aug 23 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee8abf77bec3e1265f2508e407c1c68985c89af

commit fee8abf77bec3e1265f2508e407c1c68985c89af
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Aug 25 01:47:24 2017

Fix dialogs with large icons having misaligned titles.

When I wrote crrev.com/2907983002 I accidentally changed the title
height to be the same as the icon height if the icon height is larger,
but kept the code that positioned it assuming it was smaller. This patch
reverts the title height to be the preferred height.

Bug:  740487 
Change-Id: Ie356dfa717436a20884b8805d0400f40c68b4ae3
Reviewed-on: https://chromium-review.googlesource.com/631059
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497283}
[modify] https://crrev.com/fee8abf77bec3e1265f2508e407c1c68985c89af/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/fee8abf77bec3e1265f2508e407c1c68985c89af/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/fee8abf77bec3e1265f2508e407c1c68985c89af/ui/views/bubble/bubble_frame_view_unittest.cc

Comment 4 by bsep@chromium.org, Aug 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment