Issue metadata
Sign in to add a comment
|
Regression : 'Open' and 'File info' options Tool tip are not clearly seen in 'General Info' page of Files App |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3152.0/9730.0.0 dev-channel Kip,Wolf and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download images -> Go to Files App -> Select Image -> Right Click and select 'Get info' option or click on 'Space' Key (2)Observe Default Blue focus is on 'Open' option (3)Observe Tool tip of 'Open' and 'File info' options (4)Now click on the page and focus is not on 'Open' option and try to close General information page using 'Space' Key and observe page is not getting closed (Please refer Video and screenshot) Expected: a)On opening General information page default Blue focus should not be on 'Open' option b)Tool tip of 'Open' and 'File info' options should be seen clearly c)Should be able to close 'General Info' page after step(4) Actual: Instead a)On opening General information page default Blue focus is on 'Open' option b)Tool tip of 'Open' and 'File info' options are not clearly seen c)Title, Open and Info Icons should be at bottom of the page d)Unable to close 'General Info' page after step(4) This is a Regression Issue as same is working fine in 61.0.3150.0/9720.0.0 dev channel Kip @oka: Please confirm the issue
,
Jul 19 2017
Not working on. Thank you for taking this!
,
Jul 19 2017
,
Jul 20 2017
I think it's related to this change https://codereview.chromium.org/2966163003 It's in the diff between 61.0.3152.0 and 61.0.3150.0. https://chromium.googlesource.com/chromium/src/+log/61.0.3150.0..61.0.3152.0?pretty=fuller&n=10000
,
Jul 20 2017
@mmanchala Question: Under the section 'Actual' bullet C says that 'Title, Open and Info Icons should be at bottom of the page' but in both videos is at the top of the preview window, therefore this is not an issue, right?
,
Jul 20 2017
As per comment #5 Yes Bullet c is not an Issue but Issue is regarding Bullet a,b and d under the section 'Actual'
,
Jul 20 2017
Among a, b, and d, which is the regression? I assume b is the regression and a, d are not regressions. Do I understand correctly?
,
Jul 20 2017
My current understandings are: a) Working as intended. The initial focus should be "OPEN". b) Regression d) Bug, but not regression.
,
Jul 20 2017
As per comment #8 a)Click on 'Get info' option on any Downloaded Image -> Now observe grey Focus on 'File info' option and Blue Focus on 'Open' option -> Blue Focus on 'Open' option is not seen before so it is Regression(Please refer 'Actual_a' video , 'Actual_a' Screenshot & 'Expected_a' Video) b) Tool tip of 'Open' and 'File info' options are not clearly seen. yes it is Regression (Please refer 'Actual_b' & 'Expected_b' screenshots) d)After opening General Information page -> click on the page and observe now Blue focus is not on 'Open' option and only Grey focus on 'File info' option is seen -> Now try to close General information page using 'Space' Key and observe page is not getting closed. Before we can close Get info page using 'Space' key . So it is Regression (please refer 'Actual_c' & 'Expected_c' Videos) (Please refer Video and screenshot)
,
Jul 20 2017
Thank you for the detailed explanation! I understand that all a, b, and d are regressions. We'll fix them.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9987314f39ed0a2c36dd6404d66edb338fcc53ea commit 9987314f39ed0a2c36dd6404d66edb338fcc53ea Author: Klemen Kozjek <klemenko@google.com> Date: Mon Jul 24 09:15:27 2017 Files app: Allow files quick preview to be closed with space bar and put toolbar button's tooltip above meta data info panel Bug: 740467 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib00d7619ee61f75fc9c73dcab67ce6a3a293d5b2 Reviewed-on: https://chromium-review.googlesource.com/578969 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488933} [modify] https://crrev.com/9987314f39ed0a2c36dd6404d66edb338fcc53ea/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/9987314f39ed0a2c36dd6404d66edb338fcc53ea/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/9987314f39ed0a2c36dd6404d66edb338fcc53ea/ui/file_manager/file_manager/foreground/elements/files_quick_view.js [modify] https://crrev.com/9987314f39ed0a2c36dd6404d66edb338fcc53ea/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
Jul 25 2017
,
Jul 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 25 2017
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
This issue is fixed on M62 (9784.0.0, 62.0.3166.0 dev build) but not on M61 (Chrome os 9765.9.0, 61.0.3163.16 dev build).
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1bf99ab832f6345667b36f8613ea2288b67788f commit a1bf99ab832f6345667b36f8613ea2288b67788f Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Jul 31 06:05:41 2017 Files app: Allow files quick preview to be closed with space bar and put toolbar button's tooltip above meta data info panel TBR=klemenko@google.com (cherry picked from commit 9987314f39ed0a2c36dd6404d66edb338fcc53ea) Bug: 740467 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib00d7619ee61f75fc9c73dcab67ce6a3a293d5b2 Reviewed-on: https://chromium-review.googlesource.com/578969 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488933} Reviewed-on: https://chromium-review.googlesource.com/593383 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#140} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/a1bf99ab832f6345667b36f8613ea2288b67788f/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/a1bf99ab832f6345667b36f8613ea2288b67788f/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/a1bf99ab832f6345667b36f8613ea2288b67788f/ui/file_manager/file_manager/foreground/elements/files_quick_view.js [modify] https://crrev.com/a1bf99ab832f6345667b36f8613ea2288b67788f/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
Aug 5 2017
Verified on M62 (Chrome OS 9807.0.0, 62.0.3176.0 dev build). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fukino@chromium.org
, Jul 19 2017Owner: klemenko@google.com