New issue
Advanced search Search tips

Issue 740465 link

Starred by 1 user
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Jul 2017
Cc:
dmu...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ClearBrowsingData_MaskContainsUnprotectedWeb logged twice

Project Member Reported by dullweber@chromium.org, Jul 10 2017 
ClearBrowsingData_MaskContainsUnprotectedWeb is logged twice if a browsing data deletion contains data types that are important storage (cookies or cache) and some other data type.

It should only be logged once.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f5d938ae2e6f0dda26b4fdc4564dbc8f466f5c3

commit 7f5d938ae2e6f0dda26b4fdc4564dbc8f466f5c3
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Jul 10 14:25:27 2017

Optimize clearBrowsingData without important sites

If the list of important sites is empty, we don't have to perform
two separate ClearBrowsingData calls.

Bug:  740465 
Change-Id: I585391bf1721a82a7368ba611fdd6abe54bf3276
Reviewed-on: https://chromium-review.googlesource.com/565138
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485263}
[modify] https://crrev.com/7f5d938ae2e6f0dda26b4fdc4564dbc8f466f5c3/chrome/browser/browsing_data/browsing_data_important_sites_util.cc

Comment 2 by dullweber@chromium.org, Jul 10 2017

Status: Fixed (was: Untriaged)
Fixed logging twice for deletions without important sites. If there are important sites, we still need separate calls for data types that are filtered and those that are not filtered.
►

Sign in to add a comment