Add CfM pause/play audio and video tests |
|||||||||
Issue descriptionAdd WebRTC pause/play tests to test performance on CfMs. Following up on https://bugs.chromium.org/p/chromium/issues/detail?id=718369&desc=2
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/04c3a43458026d36ea0c0f3e5c99bd13e8a892ce commit 04c3a43458026d36ea0c0f3e5c99bd13e8a892ce Author: Claes Malmnas <malmnas@google.com> Date: Mon Jul 10 22:27:22 2017 Cleanup the pause-play test a bit. * Remove unused code * Remove unused parameter to PeerConnection constructor * Use method shorthand instead of introducing consts for callbacks * Add some comments TEST=locally BUG= chromium:740464 Change-Id: I890b1c89a479f10799feee8d366b31dd140797e7 Reviewed-on: https://chromium-review.googlesource.com/563198 Commit-Ready: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Denis Tosic <dtosic@chromium.org> [modify] https://crrev.com/04c3a43458026d36ea0c0f3e5c99bd13e8a892ce/client/site_tests/video_WebRtcPausePlayPeerConnections/pause-play.js [modify] https://crrev.com/04c3a43458026d36ea0c0f3e5c99bd13e8a892ce/client/site_tests/video_WebRtcPausePlayPeerConnections/pause-play.html
,
Jul 11 2017
[Triage] Setting to assigned.
,
Jul 11 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d49da6c1e0663cf5101c01461437b63f5c900697 commit d49da6c1e0663cf5101c01461437b63f5c900697 Author: Claes Malmnas <malmnas@google.com> Date: Thu Jul 13 18:44:41 2017 Code refatoring. Remove the "video" prefix from the PausePlayPeerConnections test. This change is made to make it easy to reuse the code for an audio test. BUG= chromium:740464 TEST=locally NOTRY=true Change-Id: I1a372d040e163cf499969f979a3ceb79fd7a3820 Reviewed-on: https://chromium-review.googlesource.com/566814 Commit-Ready: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Denis Tosic <dtosic@chromium.org> [rename] https://crrev.com/d49da6c1e0663cf5101c01461437b63f5c900697/client/site_tests/webrtc_PausePlayPeerConnections/control.video [rename] https://crrev.com/d49da6c1e0663cf5101c01461437b63f5c900697/client/site_tests/webrtc_PausePlayPeerConnections/webrtc_PausePlayPeerConnections.py [rename] https://crrev.com/d49da6c1e0663cf5101c01461437b63f5c900697/client/site_tests/webrtc_PausePlayPeerConnections/pause-play.html [rename] https://crrev.com/d49da6c1e0663cf5101c01461437b63f5c900697/client/site_tests/webrtc_PausePlayPeerConnections/pause-play.js
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf87a5d21ca61717732b7397c4b02f9cf4dc343d commit cf87a5d21ca61717732b7397c4b02f9cf4dc343d Author: Claes Malmnas <malmnas@google.com> Date: Tue Jul 18 01:32:39 2017 Add an audio-only pause/play test. The test class has been updated to take a new parameter 'elementType' that is used to control whether the test should test audio or video elements. Added a new control file for an audio-only pause/play test. BUG= chromium:740464 TEST=locally Change-Id: Ifa54db4d1912207c33b4747298b3072907095559 Reviewed-on: https://chromium-review.googlesource.com/571740 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/cf87a5d21ca61717732b7397c4b02f9cf4dc343d/client/site_tests/webrtc_PausePlayPeerConnections/control.video [modify] https://crrev.com/cf87a5d21ca61717732b7397c4b02f9cf4dc343d/client/site_tests/webrtc_PausePlayPeerConnections/webrtc_PausePlayPeerConnections.py [modify] https://crrev.com/cf87a5d21ca61717732b7397c4b02f9cf4dc343d/tko/perf_upload/perf_dashboard_config.json [modify] https://crrev.com/cf87a5d21ca61717732b7397c4b02f9cf4dc343d/client/site_tests/webrtc_PausePlayPeerConnections/pause-play.js [add] https://crrev.com/cf87a5d21ca61717732b7397c4b02f9cf4dc343d/client/site_tests/webrtc_PausePlayPeerConnections/control.audio
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d2b1a4ef5ec48c0f7b149809e3bf944ca110d0ff commit d2b1a4ef5ec48c0f7b149809e3bf944ca110d0ff Author: Claes Malmnas <malmnas@google.com> Date: Fri Jul 21 02:25:57 2017 autotest-chrome: Remove non-existing test and add new tests. Removing: tests_video_WebRtcPausePlayPeerConnections Adding: +tests_webrtc_PausePlayPeerConnections.video +tests_webrtc.PausePlayPeerConnections.audio The test were renamed in https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf87a5d21ca61717732b7397c4b02f9cf4dc343d TEST=no BUG= chromium:740464 Change-Id: Iebd1ea9b3b328bcf28be2d9f6bc4b4eee6713a0b Reviewed-on: https://chromium-review.googlesource.com/579089 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/d2b1a4ef5ec48c0f7b149809e3bf944ca110d0ff/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7bf263ab0b3eaa6b86998bf12e8600eded8bae9e commit 7bf263ab0b3eaa6b86998bf12e8600eded8bae9e Author: harpreet <harpreet@google.com> Date: Thu Jul 27 22:44:03 2017 autotest-chrome: Fix test name Should be test_webrtc_PausePlayPeerConnections and not test_webrtc_PausePlayPeerConnections.video/audio. BUG= chromium:740464 TEST=None Change-Id: I75c4908274ee6f188195233eef1af445921c1384 Reviewed-on: https://chromium-review.googlesource.com/588369 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> [modify] https://crrev.com/7bf263ab0b3eaa6b86998bf12e8600eded8bae9e/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ca969bd7f9e2a1cb2429241f8cdc9faf75271b71 commit ca969bd7f9e2a1cb2429241f8cdc9faf75271b71 Author: Denis Tosic <dtosic@chromium.org> Date: Tue Aug 08 21:56:14 2017 Adds missing quotes are element type argument Not having quotes around the param causes the js code to treat the param as a reference, not as a value which triggers an exception. BUG= chromium:740464 TEST=no Change-Id: I094b9208941606ad313b159eebb15cb42e985fb0 Reviewed-on: https://chromium-review.googlesource.com/604794 Commit-Ready: Denis Tosic <dtosic@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/ca969bd7f9e2a1cb2429241f8cdc9faf75271b71/client/site_tests/webrtc_PausePlayPeerConnections/webrtc_PausePlayPeerConnections.py
,
Aug 25 2017
,
Aug 25 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 26 2017
Approving merge to M61 Chrome OS.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1fda7540481d68bd14d67bd6ff1b740707df081f commit 1fda7540481d68bd14d67bd6ff1b740707df081f Author: harpreet <harpreet@google.com> Date: Sat Aug 26 01:07:16 2017 autotest-chrome: Fix test name Should be test_webrtc_PausePlayPeerConnections and not test_webrtc_PausePlayPeerConnections.video/audio. BUG= chromium:740464 TEST=None Change-Id: I75c4908274ee6f188195233eef1af445921c1384 Reviewed-on: https://chromium-review.googlesource.com/588369 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Reviewed-by: Kalin Stoyanov <kalin@chromium.org> (cherry picked from commit 7bf263ab0b3eaa6b86998bf12e8600eded8bae9e) Reviewed-on: https://chromium-review.googlesource.com/635948 Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Commit-Queue: Harpreet Grewal <harpreet@chromium.org> Trybot-Ready: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/1fda7540481d68bd14d67bd6ff1b740707df081f/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d25e78d732d77b01b69718dd8d2ab242d8718a51 commit d25e78d732d77b01b69718dd8d2ab242d8718a51 Author: Denis Tosic <dtosic@chromium.org> Date: Sat Aug 26 01:07:16 2017 Adds missing quotes are element type argument Not having quotes around the param causes the js code to treat the param as a reference, not as a value which triggers an exception. BUG= chromium:740464 TEST=no Change-Id: I094b9208941606ad313b159eebb15cb42e985fb0 Reviewed-on: https://chromium-review.googlesource.com/604794 Commit-Ready: Denis Tosic <dtosic@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> (cherry picked from commit ca969bd7f9e2a1cb2429241f8cdc9faf75271b71) Reviewed-on: https://chromium-review.googlesource.com/636225 Commit-Queue: Harpreet Grewal <harpreet@chromium.org> Trybot-Ready: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/d25e78d732d77b01b69718dd8d2ab242d8718a51/client/site_tests/webrtc_PausePlayPeerConnections/webrtc_PausePlayPeerConnections.py
,
Aug 29 2017
,
Aug 29 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 1 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ehmaldonado@chromium.org
, Jul 10 2017