New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740462 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 583292
issue 751534



Sign in to add a comment

[Local NTP] OGB: Use cookie auth

Project Member Reported by treib@chromium.org, Jul 10 2017

Issue description

The OneGoogleBar on the local NTP should use content area sign-in state (i.e. cookies) instead of Chrome sign-in state (OAuth2).
 

Comment 1 by fi...@chromium.org, Jul 20 2017

Labels: -Type-Bug M-62 zine-triaged Type-Feature

Comment 2 by treib@chromium.org, Aug 2 2017

Blocking: 751534
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2

commit 042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2
Author: Marc Treib <treib@chromium.org>
Date: Fri Aug 04 13:28:22 2017

OneGoogleBar on local NTP: Use cookie auth instead of OAuth2

This is achieved by talking to a different endpoint for fetching the
OGB sources, which accepts cookies. As a consequence, the cached data
is now cleared when the Gaia cookies change, rather than when the
SigninManager state changes.

Bug:  740462 
Change-Id: Id230a118507e32e6f1a17c103c93c8eb5ccb0ba6
Reviewed-on: https://chromium-review.googlesource.com/595990
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492008}
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.h
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl_unittest.cc
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_service.cc
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_service.h
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_service_factory.cc
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
[modify] https://crrev.com/042810ea7bce7b9fcc17ad12f308b4d9b6db0ff2/chrome/browser/ui/search/local_ntp_browsertest.cc

Comment 4 by treib@chromium.org, Aug 4 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6b0ad5d57e7793576286bab0585b947d9c1f15e

commit e6b0ad5d57e7793576286bab0585b947d9c1f15e
Author: Marc Treib <treib@chromium.org>
Date: Fri Aug 11 12:01:34 2017

OneGoogleBarService: don't notify on signin state change if cache is empty

A change to the signin state causes the OneGoogleBarService to clear its
cache. If the cache was already empty before, there is no need to notify
observers. This fixes a bug where the One Google Bar sometimes doesn't
appear on the first NTP right after Chrome startup, where the following
happened:
- LocalNtpSource calls OneGoogleBarService::Refresh.
- Before the request completes, the service gets a signin change
  notification (maybe because some cookies got loaded from disk?) and
  tells the LocalNtpSource "there's no OGB right now".
- The request finishes successfully, but the NTP has already gotten the
  "no OGB" notification.

Bug:  740462 
Change-Id: I94144c9f32a33d140261558dfaf8be36a5126061
Reviewed-on: https://chromium-review.googlesource.com/612166
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493705}
[modify] https://crrev.com/e6b0ad5d57e7793576286bab0585b947d9c1f15e/chrome/browser/search/one_google_bar/one_google_bar_service.cc
[modify] https://crrev.com/e6b0ad5d57e7793576286bab0585b947d9c1f15e/chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc

Sign in to add a comment