New issue
Advanced search Search tips

Issue 740461 link

Starred by 1 user
Status: Assigned
Owner:
creis@chromium.org
Cc:
a...@chromium.org
arthurso...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

NavigationEntry: subframe navigation doesn't update PageTransition.

Project Member Reported by arthurso...@chromium.org, Jul 10 2017 
It looks like the PageTransition used in the NavigationController for subframe navigation are not the one dedicated to subframe (i.e. PAGE_TRANSITION_{AUTO, MANUAL}_SUBFRAME) but the one of the main frame.

For instance:

* Navigation to a page A with an iframe B
    In FrameHostMsg_DidCommitProvisionalLoad:
      A -> PAGE_TRANSITION_LINK | PAGE_TRANSITION_FROM_ADDRESS_BAR
      B -> PAGE_TRANSITION_AUTO_SUBFRAME
    In NavigationControllerImpl:
      entries[0] -> PAGE_TRANSITION_LINK | PAGE_TRANSITION_FROM_ADDRESS_BAR

* Then B navigates.
    In FrameHostMsg_DidCommitProvisionalLoad:
      B -> PAGE_TRANSITION_MANUAL_SUBFRAME
    In NavigationControllerImpl:
      entries[1] -> PAGE_TRANSITION_LINK | PAGE_TRANSITION_FROM_ADDRESS_BAR

Some old comments suggests that PAGE_TRANSITION_MANUAL_SUBFRAME was used in the NavigationControllerImpl for the second navigation. Maybe the switch to FrameNavigationEntries made it so that we don't update the transition type of the NavigationEntry anymore.

What to do is an open question.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b757c63d2e76e4ea078e3ca4ca873d5b594073ea

commit b757c63d2e76e4ea078e3ca4ca873d5b594073ea
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon Jul 10 16:16:14 2017

PageTransition: Remove unreached code.

Remove a block of code that used to detect a incorrect PageTransition
and to replace it by its correct value.
Apparently, this block is no more reached. This CL removes it.
Furthermore, a test is added. It replays the steps one had to do to
reach this block of code.

BUG=736772,740461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2961903003
Cr-Commit-Position: refs/heads/master@{#485287}

[modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/renderer/render_frame_impl.cc
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 4 by arthurso...@chromium.org, Aug 7

Labels: -Hotlist-Recharge-Cold
►

Sign in to add a comment