What steps will reproduce the problem? (1) Open ContentSuggestions (2) Scroll What is the expected result? The scroll should be smooth What happens instead? There is a perceptible lag at the beginning of the gesture
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dc54c17e0b7662e8bed381aa0a17af6892d6650 commit 2dc54c17e0b7662e8bed381aa0a17af6892d6650 Author: gambard <gambard@chromium.org> Date: Tue Jul 11 08:43:28 2017 Pre-calculate height of ContentSuggestions cells The height of the ContentSuggestions cells were calculated using auto layout. This introduce a lag when the layout is invalidated, visible when a scrolling gesture is started. Using a pre-calculated height allow us to reduce the compute time and eliminate the lag. BUG= 740450 Change-Id: I64f0e670c460d8fbce5a2af9001fa874fa41d55c Reviewed-on: https://chromium-review.googlesource.com/563669 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#485561} [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.h [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/cells/suggested_content.h [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/showcase/content_suggestions/sc_content_suggestions_item.mm [modify] https://crrev.com/2dc54c17e0b7662e8bed381aa0a17af6892d6650/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm
Issue 740931 has been merged into this issue.
Comment 1 by gambard@chromium.org
, Jul 10 2017