New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740439 link

Starred by 1 user
Status: Duplicate
Merged: issue 735071
Owner:
yhirano@chromium.org
Closed: Jul 2017
Cc:
yhirano@chromium.org
█ nainar@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

17.5% improvement in system_health.memory_mobile at 480313:480379

Project Member Reported by yhirano@chromium.org, Jul 10 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 10 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=740439

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cc9b9260fcb8d94749cdecd0ab25d9b90b60bbf14eb7571cd7afd8fd8067c5f5


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 10 2017 


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_instagram
  Change       : 11.40% | 220208090.286 -> 195113026.286

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/b2bea37ff0b2955f79a8d88d87e61e6a82429255..94f22629bdee3f65163cee9ba89d5d72cdfbe0fb


Revision             Result                     N
chromium@480312      220208090 +- 67820598      14       good
chromium@480329      233933646 +- 66538002      14       good
chromium@480330      ---                        ---      build failure
chromium@480331      232293174 +- 61582424      14       bad
chromium@480332      226974104 +- 54434973      9        bad
chromium@480334      206716888 +- 0.0           6        bad
chromium@480338      212684688 +- 32686987      6        bad
chromium@480346      187173016 +- 47872514      6        bad
chromium@480379      195113026 +- 83947997      14       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974476410005755216


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 10 2017

Cc: nainar@chromium.org
Owner: nainar@chromium.org

=== Auto-CCing suspected CL author nainar@chromium.org ===

Hi nainar@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Naina Raisinghani
  Commit : cd4e730743d522affeae07a1280792359f7856b1
  Date   : Mon Jun 19 04:16:45 2017
  Subject: Generate enum/getters/setters/mappings for PageSizeType and generate getters/setters for PageSize.

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_instagram
  Change       : 18.99% | 222995570.667 -> 180658392.0

Revision             Result                     N
chromium@480312      222995571 +- 54674244      9       good
chromium@480329      225167112 +- 45272961      6       good
chromium@480338      220110685 +- 73477259      9       good
chromium@480342      195548961 +- 86145192      14      good
chromium@480343      173596944 +- 46226380      12      bad       <--
chromium@480346      178871793 +- 86015375      14      bad
chromium@480379      180658392 +- 45134639      6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974461995172097024


For feedback, file a bug with component Speed>Bisection

Comment 7 by yhirano@chromium.org, Jul 11 2017

Owner: yhirano@chromium.org
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jul 11 2017

Mergedinto: 735071
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Yutaka Hirano
  Commit : 84047549ac37bab70d7306566c912e59131f3e1f
  Date   : Mon Jun 19 04:16:15 2017
  Subject: [Loading] Save one post-task when the data pipe is ready on arrival

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_instagram
  Change       : 16.11% | 230438604.571 -> 193323090.667

Revision             Result                     N
chromium@480312      230438605 +- 86336218      14      good
chromium@480329      217416109 +- 65374462      14      good
chromium@480338      225167112 +- 45272961      6       good
chromium@480340      225713936 +- 46610121      6       good
chromium@480341      219199312 +- 43302577      6       good
chromium@480342      184636925 +- 57116552      9       bad       <--
chromium@480346      185001475 +- 58268568      9       bad
chromium@480379      193323091 +- 77688345      9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.instagram system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974403104462820128


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment