New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740434 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Added extension does not disappear from 'Open New Tab page' after clicking on 'Disable' button

Reported by sans...@etouch.net, Jul 10 2017 
Chrome Version: 61.0.3153.0 (Official Build) 4b9102f9588fb6cf639a6165fd4777658d5ade0d-refs/heads/master@{#485143}-32/64 bit
OS: Windows (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).

URL: https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca?hl=en

Steps:
1. Launch Chrome and add above extension (url given)
2. Navigate to chrome://settings/startupUrls, click on 'Disable' button of added extension and observe

Actual: Added extension does not disappear from 'Open New Tab page' after clicking on 'Disable' button

Expected: Added extension should disappear from 'Open New Tab page' after clicking on 'Disable' button

This is Regression Issue broken in M-61 and will soon update the bisect info.

Manual Bisect Info:
Good Build: 61.0.3152.0
Bad Build: 61.0.3153.0
Actual_video.mp4
273 KB View Download
Expected_video.mp4
149 KB View Download

Comment 1 by rbasuvula@chromium.org, Jul 10 2017

Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3152.0(Revision:485105).
Bad build:61.0.3153.0(Revision:485143).

You are probably looking for a change made after 485129 (known good), but no later than 485130 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/1ce01d74264f25346da3b01f9fc3accaa91a1dd7..b1b6f101f5078d42160af02e26bd5c3c27a03100

From the CL above, assigning the issue to the concern owner

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://chromium-review.googlesource.com/557971
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3153.0

Comment 2 by dschuyler@chromium.org, Jul 10 2017

Status: Started (was: Assigned)
Thanks for finding this!
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb650155bad4fdb212e51277083ff56acfe11af3

commit bb650155bad4fdb212e51277083ff56acfe11af3
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Jul 11 00:43:44 2017

[MD settings] remove UI about extension controlling ntp on disable

This CL removes the note about an extension controlling the NTP from the
OnStartup URL list when the extension is disabled (since it's no longer
being controlled by that extension).

This fixes an error I'd made in CL 557971.

Bug:  740434 
Change-Id: I80fea69068b24198ea28478210fbff6bebf8cb7a
Reviewed-on: https://chromium-review.googlesource.com/565998
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485465}
[modify] https://crrev.com/bb650155bad4fdb212e51277083ff56acfe11af3/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Comment 5 by dschuyler@chromium.org, Jul 11 2017

Status: Fixed (was: Started)

Comment 6 by sans...@etouch.net, Jul 18 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3159.5
Note: Above issue is fixed on latest Dev version 61.0.3159.5 on Mac, Windows and Linux OS

Thanks you.

Comment 7 by sans...@etouch.net, Jul 18 2017

Fixed_video.mp4
368 KB View Download
►

Sign in to add a comment