I am trying to revert r473830 (or restore equivalent functionality to before that revision). When I do this at around r484172, 3 SpokenFeedbackTest tests fail because ChromeVox reads the wrong thing.

This is baffling because this test did *not* fail before r473830 and the test itself has not changed in the interim. Something else is changing.

Specifically:

1. At r473829: SpokenFeedbackTest.FocusToolbar passes.
2. At r484172: SpokenFeedbackTest.FocusToolbar passes.
3. At r484172, revert r473830: SpokenFeedbackTest.FocusToolbar fails.

$ git revert c603f3c7e6a01188ba81015e5354e4797a017f45
$ ninja -j1000 -C out/Release_chromeos interactive_ui_tests
$ out/Release_chromeos/interactive_ui_tests --gtest_filter='*SpokenFeedbackTest.FocusToolbar*'
[2290:2290:0710/144122.751746:INFO:speech_monitor.cc(107)] Speaking chrome vox spoken feedback is ready
[2290:2290:0710/144122.830543:INFO:speech_monitor.cc(107)] Speaking Address and search bar
../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:696: Failure
      Expected: "Reload"
To be equal to: speech_monitor_.GetNextUtterance()
      Which is: "Address and search bar"
[2290:2290:0710/144122.862054:INFO:speech_monitor.cc(107)] Speaking Reload
../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:697: Failure
      Expected: "Button"
To be equal to: speech_monitor_.GetNextUtterance()
      Which is: "Reload"
[  FAILED  ] GuestSpokenFeedbackTest.FocusToolbar, where TypeParam =  and GetParam() =  (6165 ms)
[----------] 1 test from GuestSpokenFeedbackTest (6165 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (6165 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GuestSpokenFeedbackTest.FocusToolbar, where TypeParam =  and GetParam() = 

 1 FAILED TEST

All three tests fail with the same error:
    GuestSpokenFeedbackTest.FocusToolbar
    TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0
    TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1

Something has changed in between r473830 and r484172 which causes this test to fail when OmniboxViewViews behaves exactly as it did previously.

Analysis:

The test is equivalent to opening a new tab, then pressing Alt+Shift+T (focus toolbar), which focuses the reload button.

It expects ChromeVox to read "Reload" then "Button".

In the version with my commit reverted, it reads "Address and search bar" then "Reload" then "Button".

What reverting my CL does is: it makes OmniboxViewViews::OnBlur deselect the text in the Omnibox. It doesn't make any logical sense that this would trigger an additional utterance about the address bar being selected. This utterance isn't heard when trying this in an actual environment, only in the test. I assume something has been changed in the Textfield class to make an additional voice command read when the selection changes.

This is a nightmare yak; any help would be appreciated.

PS. GuestSpokenFeedbackTest.FocusToolbar (the only test in GuestSpokenFeedbackTest) is completely redundant for TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1; they test exactly the same thing under the same condition. GuestSpokenFeedbackTest can be deleted.