New issue
Advanced search Search tips

Issue 740426 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in gl::Texture::getWidth

Project Member Reported by ClusterFuzz, Jul 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4602300000894976

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x615000004880
Crash State:
  gl::Texture::getWidth
  gl::ValidateCopyTextureCHROMIUM
  gl::CopyTextureCHROMIUM
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=474850:474888

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4602300000894976


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 10 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 10 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 10 2017

Labels: Pri-1
Components: Internals>GPU>ANGLE
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
Speculatively assign to geofflang@chromium.org.

geofflang@, could you see if this is related to
https://chromium.googlesource.com/angle/angle.git/+/4f0e003e5739e369aec2ed8c5eecf78052ab5650 ?
If not, please help us find the right owner of this issue.  Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3847f94d17231889ef1c39f6a5a411130d2cfb30

commit 3847f94d17231889ef1c39f6a5a411130d2cfb30
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jul 12 15:17:28 2017

Validate that the mip level is not too large for CopyTextureCHROMIUM.

When the mip level was greater than the maximum, it could cause an
out-of-bounds read when trying to query the Texture's size and format
later in the validation.

BUG= 740426 

Change-Id: Ibd6c977981e5f8b7368c161b7969d9e916c6095b

[modify] https://crrev.com/3847f94d17231889ef1c39f6a5a411130d2cfb30/src/libANGLE/validationES2.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4939be8f314a0138d711da73ebe47da8a60ec110

commit 4939be8f314a0138d711da73ebe47da8a60ec110
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jul 13 16:55:48 2017

Roll ANGLE 70c95fa..3ec7568

https://chromium.googlesource.com/angle/angle.git/+log/70c95fa..3ec7568

BUG=:angleproject:2101,740426

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I302d09829846c705e5e337ff071098fc91bc96e5
Reviewed-on: https://chromium-review.googlesource.com/570379
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486413}
[modify] https://crrev.com/4939be8f314a0138d711da73ebe47da8a60ec110/DEPS

Project Member

Comment 7 by ClusterFuzz, Jul 14 2017

ClusterFuzz has detected this issue as fixed in range 486405:486474.

Detailed report: https://clusterfuzz.com/testcase?key=4602300000894976

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x615000004880
Crash State:
  gl::Texture::getWidth
  gl::ValidateCopyTextureCHROMIUM
  gl::CopyTextureCHROMIUM
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=474850:474888
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=486405:486474

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4602300000894976


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4602300000894976 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 14 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-60
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 16 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 8 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -ReleaseBlock-Stable -Merge-Review-60
No need for a merge.  This code is not used in production.
Labels: -Security_Impact-Beta Security_Impact-None
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 22 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment