New issue
Advanced search Search tips

Issue 740395 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Jan 2018
Cc:
elawrence@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Move Mark-Non-Secure-As to use a more modern field trial configuration

Project Member Reported by elawrence@chromium.org, Jul 9 2017 
The Chrome code follows a now outdated pattern where the group name (e.g. from base::FieldTrialList::FindFullName("MarkNonSecureAs")) is used as a literal that controls what behavior to use.

This has bit us a number times in assorted places (e.g. with Test configuration; also, Dogfood Finch trial names are supposed to end in _Dogfood, and ours cannot because we do exact string matches. Changing the Chrome code to compare against experiment name prefixes was the old way of having a more flexible study setup.

Replacement: Feature api (go/feature-api) is one route. 

Most likely key/value params (go/finch-params) is the way to go, as it provides us with deeper control over experiments beyond just turning things on and off.

Comment 1 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 2 by est...@chromium.org, Dec 22 2017

Cc: elawrence@chromium.org
Owner: est...@chromium.org
doing this as part of  issue 797437
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafa9066eb6ea9524d9022f6daa9d453d75acc15

commit bafa9066eb6ea9524d9022f6daa9d453d75acc15
Author: Emily Stark <estark@google.com>
Date: Wed Jan 03 23:20:56 2018

Move HTTP-Bad to Feature API and implement new options

This CL moves the HTTP-Bad from outdated field trial groups to the Feature API
with parameters to control the UI treatment. It adds three new UI treatments for
nonsecure  pages:

- mark all nonsecure pages as Not Secure
- mark all nonsecure pages as Not Secure and treat them as actively dangerous when
  a form field is edited
- mark all nonsecure pages as Not Secure and treat them as actively dangerous for
  passwords and credit card fields

This doesn't implement any DevTools or Page Info changes for these configurations.

Bug:  797437 , 740395 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I646502a05967b63d3c34015d0d597ce5382248f9
Reviewed-on: https://chromium-review.googlesource.com/843456
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526857}
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/about_flags.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/ssl/security_state_tab_helper_unittest.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/content/content_utils_unittest.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/core/BUILD.gn
[add] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/core/features.cc
[add] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/core/features.h
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/core/security_state.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/components/security_state/core/security_state_unittest.cc
[delete] https://crrev.com/adf3024430761a623b44a81e4b38abdd1c3b38ca/components/security_state/core/switches.cc
[delete] https://crrev.com/adf3024430761a623b44a81e4b38abdd1c3b38ca/components/security_state/core/switches.h
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/bafa9066eb6ea9524d9022f6daa9d453d75acc15/tools/metrics/histograms/histograms.xml

Comment 4 by est...@chromium.org, Jan 4 2018

Labels: M-65 OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)
►

Sign in to add a comment