The code behind this ifdef doesn't seem to be used. https://cs.chromium.org/search/?q=NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES&sq=package:chromium&type=cs
Maybe we can get rid of it. In the past I've had very unexpected consequences of changing Mac things like this. Best approach is probably to try it and see what happens.
Good idea, I'll give it a try and see what happens.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec144f1315b08bd1440c29b655b3ae88bf64d17a commit ec144f1315b08bd1440c29b655b3ae88bf64d17a Author: Emil A Eklund <eae@chromium.org> Date: Mon Jul 10 20:46:28 2017 Remove NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES Remove the NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES define and the Mac OS specific code guarded by it as it is no longer used. Bug: 740391 Change-Id: If7320d4bf9ec359fb437df644440d4df0e3e3318 Reviewed-on: https://chromium-review.googlesource.com/565464 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#485368} [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/FloatPoint.h [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/FloatRect.h [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/FloatSize.h [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/IntPoint.h [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/IntRect.h [modify] https://crrev.com/ec144f1315b08bd1440c29b655b3ae88bf64d17a/third_party/WebKit/Source/platform/geometry/IntSize.h [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/FloatPointMac.mm [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/FloatRectMac.mm [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/FloatSizeMac.mm [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/IntPointMac.mm [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/IntRectMac.mm [delete] https://crrev.com/689e3bdcb4837e14c1f3f659591f96bc18cd17fe/third_party/WebKit/Source/platform/geometry/mac/IntSizeMac.mm
Comment 1 by schenney@chromium.org
, Jul 10 2017