Support federated credentials in the detailed password view in iOS settings |
||||
Issue descriptionPart of the support for viewing credentials on iOS (bug 739404) should be also viewing federated credentials. Those have no password stored, instead they store an identity provider in form of a password domain. On desktop, these passwords are presented by replacing the password with the provider domain, as documented on the first screenshot. On iOS, in the new settings (behind the "Enable View/Copy passwords" experimental setting), the federation is not shown, and instead an empty password is presented (second screenshot). This should be changed to match desktop.
,
Jul 9 2017
Adding the screenshot with the proposed solution.
,
Jul 9 2017
The CL with the above is https://chromium-review.googlesource.com/c/563623/
,
Jul 10 2017
Solution proposed sounds good to me. However, "With Federation" looks and sounds a bit weird. I am not sure the word "Federation" makes sense to the end-user (Federated log-in being a bit of a technical term). Ideas welcome. Would "Authentication Provider" be better than "With Federation" ? I am adding Shimi to this bug to weigh on the string to be used here. Thank you.
,
Jul 10 2017
Thanks! I was not sure about the string myself. I'm very happy to change it, so looking forward to Shimi's input.
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7020c4e0d2a6b5943ef920e5a14054ab4b198da9 commit 7020c4e0d2a6b5943ef920e5a14054ab4b198da9 Author: Vaclav Brozek <vabr@chromium.org> Date: Mon Jul 10 21:50:36 2017 Support federated credentials in password settings on iOS The current implementation of the password detail view in iOS settings tries to display the password value, which federated credentials have none. Instead, they have a web origin identifying the federated identity provider associated with the stored credential. This origin is currently not displayed. Therefore this CL changes the password detail view for federated credentials by replacing the password section with a federation section. The federation origin is very likely to be just a short hostname which fits on one line so there is no copy button for it as in the case of the other meta data. Desktop settings already do something similar: they replace the password field with a "with <federation origin>" string. Screenshot at https://crbug.com/740384#c2 . Bug: 740384 Change-Id: Ibf4ff13a864fab450b3558246d8b26e04182b804 Reviewed-on: https://chromium-review.googlesource.com/563623 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485410} [modify] https://crrev.com/7020c4e0d2a6b5943ef920e5a14054ab4b198da9/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/7020c4e0d2a6b5943ef920e5a14054ab4b198da9/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm [modify] https://crrev.com/7020c4e0d2a6b5943ef920e5a14054ab4b198da9/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm [modify] https://crrev.com/7020c4e0d2a6b5943ef920e5a14054ab4b198da9/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
,
Jul 11 2017
TBH I have no idea what federated credentials are. I hope Shimi does? This is probably a case where those who have such credentials in their password store would understand the unique labels and "password" presentation, but nonetheless it would be good for us [designers] to understand this feature. Václav: would the cell representing the detail VC use just the federated domain or would it prepend the word "with" like on desktop?
,
Jul 11 2017
Federated credentials are new, they can only be added via the new Credential Management API (https://w3c.github.io/webappsec-credential-management), not via a HTML form. They serve as a stored record of users consent to identify on the origin ("Site") of the stored federated credential through an identity provider ("Federation"). An example would be a user on somesmallsite.com not bothering to fill in their sign-up form but rather choosing "Log in with Facebook", and then allowing somesmallsite.com to ask Facebook about their identity directly. Wikipedia has an article on that (https://en.wikipedia.org/wiki/Federated_identity) as well. As for "with": I would like not to put it in the same cell as the federation hostname. The section header for that cell should be phrased so that listing just the hostname would make sense (what Mardini suggests in #4 works that way). I think the desktop's "with" is just a crutch, because there is no section header there, it's all in one row.
,
Jul 11 2017
Thanks for the background, Václav! I will read up on this more. Regarding my "with" prepend question, it was about in the context of the list of saved password cells rather than in the header of the detail view controller.
,
Jul 11 2017
Thanks, Pete. Still not sure if I understand your question about with, so let me rephrase: In the list view, where the passwords are listed as: http://example.origin.com some username in grey you are asking whether the federated hostname should also be displayed and whether it should be prefixed by "with"? If so, then I suggest not to mention the federated hostname in that list at all (=current state). It should only be listed on places where otherwise the password is listed (that's how it works on desktop), which on iOS is only the detailed view. I forgot to say that who wants to play with the federated credentials, can easily save two on https://w3c.github.io/webappsec/demos/credential-management/, just click Sign In, then one of the "Sign in via..." buttons, and accept to save that password. However, this can only be done on non-iOS platforms (iOS support will come later), and synced on the iOS device. Please let me know what you think about the "with" issue.
,
Jul 18 2017
Going back to c#4, the header, how about "Signed In With"? Federated sign-in UIs usually use language like "Sign in/log in with Facebook". So the notion of "sign in with" is more familiar than technical terms like "federation" or "authentication." FYI, "Sign in" is preferred over "log in." (Re: capitalization, I'm following the Apple guideline of capitalizing prepositions when they are part of a verb phrase, even if they are shorter than four letters.)
,
Jul 19 2017
Thank you! "Signed In With" makes good sense to me, and it really seems a great way to avoid hard-to-understand technical terms. I will change the string shortly.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/574f0bf33a61976d995c14e979d295f3bea8bb39 commit 574f0bf33a61976d995c14e979d295f3bea8bb39 Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Jul 19 10:00:48 2017 Adjust strings in passwords settings on iOS This CL adjusts strings used in the passwords detail view, based on the following guidance from UX: * https://crbug.com/740379#c9 Shortening "Delete Saved Password" to just "Delete" * https://crbug.com/740384#c11 Identifying the federation URL with "Signed In With" * https://crbug.com/742290#c1 Improving the copy toasts: URL -> address, simpler phrasing and no full-stops for one-sentence messages Bug: 740379 , 740384 , 742290 Change-Id: I1eec2a44fd5d2acd59166988431832e88f8737e6 Reviewed-on: https://chromium-review.googlesource.com/577528 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487810} [modify] https://crrev.com/574f0bf33a61976d995c14e979d295f3bea8bb39/ios/chrome/app/strings/ios_strings.grd
,
Jul 19 2017
,
Sep 22 2017
Verified as per #8 in IOS 10.3.3, 11.0 iPad Pro 12'5, iPhone7+ Verification Steps: 1. Go to https://w3c.github.io/webappsec-credential-management in Chrome Desktop. 2. Sign In, Save Password in Chrome desktop. 3. Sync saved federated password to iOS device. https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClRUxvXy15cmpfYTg/view?usp=sharing |
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted