New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

ChildProcessCreationParams belongs in content/ not base/

Project Member Reported by jcivelli@chromium.org, Jul 8 2017

Issue description

The various process launcher classes in base (ChildProcessLauncher, ChildProcessConnection, ChildConnectionAllocator...) do no have to depend on ChildProcessCreationParams. We should remove the dependency to it from all of these classes and move ChildProcessCreationParams to content.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917a15f28de33bbe32a2a3d08c08afbb300b8891

commit 917a15f28de33bbe32a2a3d08c08afbb300b8891
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Jul 14 01:13:06 2017

Moving ChildProcessCreationParams from base to content.

The various process launcher classes in base (ChildProcessLauncher,
ChildProcessConnection, ChildConnectionAllocator...) do no have to
depend on ChildProcessCreationParams.
Removing that dependency and moving ChildProcessCreationParams to
content.

TBR=tedchoc

Bug:  740341 
Change-Id: Ic1a4cb08ca60f88b60d619fef22c9761de0f9a36
Reviewed-on: https://chromium-review.googlesource.com/563721
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486587}
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/base/BUILD.gn
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/base/android/java/src/org/chromium/base/process_launcher/ChildConnectionAllocator.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/base/android/java/src/org/chromium/base/process_launcher/ChildProcessConnection.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/base/android/junit/src/org/chromium/base/process_launcher/ChildConnectionAllocatorTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/BUILD.gn
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
[rename] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/junit/src/org/chromium/content/browser/ChildProcessConnectionTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/junit/src/org/chromium/content/browser/SpareChildConnectionTest.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/public/android/junit/src/org/chromium/content/browser/TestChildProcessConnection.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java
[modify] https://crrev.com/917a15f28de33bbe32a2a3d08c08afbb300b8891/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java

Status: Fixed (was: Untriaged)

Sign in to add a comment