New issue
Advanced search Search tips

Issue 740310 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

it's weird that GraphicsLayer::painting_phase_ doesn't correspond to BackgroundPaintLocation

Project Member Reported by skobes@chromium.org, Jul 8 2017

Issue description

In overflow scrollers, CompositedLayerMapping::UpdatePaintingPhases sets kGraphicsLayerPaintBackground on graphics_layer_ but not scrolling_contents_layer_.

This happens even when PaintLayer::GetBackgroundPaintLocation wants the background painted into the scrolling contents layer.

CLM::PaintContents then has to work around this by inverting the kPaintLayerPaintingSkipRootBackground flag when background_paints_onto_scrolling_contents_layer_ is set.

I wonder if CLM could set kGraphicsLayerPaintBackground on the layers that actually paint backgrounds?  Then we could simplify the awkwardness around kPaintLayerPaintingSkipRootBackground and maybe get rid of background_paints_onto_scrolling_contents_layer_ and background_paints_onto_graphics_layer_.

It might also let us get rid of the SkipRootBackground() check in BoxPainter::PaintBoxDecorationBackgroundWithRect.  If the main GraphicsLayer isn't painting the background then it shouldn't even call into in this method, but it does because PaintLayerPainter saw kPaintLayerPaintingCompositingBackgroundPhase.

There are probably issues with this that I haven't thought of. :)
 
Labels: TE-NeedsTriageHelp
Labels: -TE-NeedsTriageHelp BugSource-Chromium PaintTeamTriaged-20170710
Status: Available (was: Unconfirmed)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment