New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740290 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Remove double reauth in settings

Project Member Reported by tengs@chromium.org, Jul 8 2017

Issue description

In the new settings page, the user must reauth with their password in order to access the lock screen settings.

We should remove the old EasyUnlock reauth, which is now unnecessary.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc9091571357eae3bf48984edf6c3a265633636

commit 3bc9091571357eae3bf48984edf6c3a265633636
Author: Tim Song <tengs@chromium.org>
Date: Thu Jul 13 02:22:20 2017

[EasyUnlock] Remove double reauth with setting up EasyUnlock.

With the new ChromeOS settings page, accessing the lock screen settings requires
the user to reauth with their password. This obsoletes the previous behaviour of
reauthing specifically for EasyUnlock.

BUG= 740290 

Change-Id: I4788e81a750fb36217a4de3bff8e1e5505985bc2
Reviewed-on: https://chromium-review.googlesource.com/565778
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486225}
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/signin/easy_unlock_service.h
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/3bc9091571357eae3bf48984edf6c3a265633636/chrome/browser/signin/easy_unlock_service_regular.h

Is this fixed? Do still need to do something else here?

Comment 3 by tengs@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
Nope, this is all done :)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment