MD Extension: clicking on extensions/apps on side-menu should close side-menu. |
|||||
Issue descriptionThe side-menu currently doesn't change when you click between extensions/apps, because the page is not actually navigating (it's just setting iron-list.items programmatically).
,
Jul 12 2017
,
Jul 12 2017
Would this get automatically fixed by migrating the side bar to cr-drawer?
,
Jul 12 2017
The sidebar is already contained in a cr-drawer element.
,
Aug 17 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/530965cc9cf880a48cfad9e4ab25758ed646e711 commit 530965cc9cf880a48cfad9e4ab25758ed646e711 Author: Scott Chen <scottchen@chromium.org> Date: Mon Aug 28 19:42:55 2017 MD Extensions: differentiate between extensions and apps page This CL adds a new "/apps" route, so that users can directly go to the apps list without having to go to the extensions page first. This CL also helps differentiate the page state between the extensions and the apps view, as well as adding a fade-in animation when switching between the two. Bug: 740279 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbc3d327b0a0fead8562fbb3b4de2d491b25fb56 Reviewed-on: https://chromium-review.googlesource.com/619587 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#497847} [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/compiled_resources2.gyp [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/navigation_helper.js [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/sidebar.html [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/sidebar.js [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/browser/resources/md_extensions/view_manager.js [modify] https://crrev.com/530965cc9cf880a48cfad9e4ab25758ed646e711/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
,
Aug 29 2017
,
Mar 12 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, Jul 7 2017