New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740270 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 647283
issue 738514



Sign in to add a comment

Record the actual PPD used to configure a printer

Project Member Reported by skau@chromium.org, Jul 7 2017

Issue description

In order to track usage of PPDs and what printers they work with, record the PPD selected during setup along with the detected printer make and model name.
 

Comment 1 by skau@chromium.org, Jul 7 2017

Blocking: 647283

Comment 2 by skau@chromium.org, Jul 7 2017

Blocking: 738514
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7193d347a565c5e3f1e5eef810dab2c5e97402

commit 1f7193d347a565c5e3f1e5eef810dab2c5e97402
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 03 18:29:28 2017

Record USB printers installed automatically.

USB printers are installed automatically if we are sure of the
configuration.  Log these printers with USB attributes and the fact
that they were configured automatically.

Bug:  740270 ,  725739 
Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681
Reviewed-on: https://chromium-review.googlesource.com/598691
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491800}
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/usb_printer_detector.cc

Comment 4 by skau@chromium.org, Aug 3 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2027281ba9565edf3ed5dd745de6b734d5abc6ed

commit 2027281ba9565edf3ed5dd745de6b734d5abc6ed
Author: Sean Kau <skau@chromium.org>
Date: Mon Aug 14 19:39:47 2017

Record printer installation metrics for automatic and manual installs.

Record IPP make and model information, USB information, and chosen
PPD data for printers installed from the printer setup page.

Bug:  740270 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I08c34e54694de3eadf3647d16ff052f1ef848eb6
Reviewed-on: https://chromium-review.googlesource.com/600890
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494133}
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/2027281ba9565edf3ed5dd745de6b734d5abc6ed/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Comment 6 by skau@chromium.org, Aug 14 2017

Status: Fixed (was: Started)

Comment 7 by skau@chromium.org, Aug 14 2017

Labels: Merge-Request-61
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 15 2017

Labels: -Merge-Request-61 Hotlist-Merge-Reject Merge-Reject-61
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: keta...@chromium.org
Labels: -Hotlist-Merge-Reject -Merge-Reject-61 M-61 Merge-Request-61
+ketakid@ - Re-requesting the merge back to M61 due to auto-reject.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 15 2017

Labels: -Merge-Request-61 Hotlist-Merge-Reject Merge-Reject-61
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Reject -Merge-Reject-61 Merge-Request-61
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 15 2017

Labels: -Merge-Request-61 Hotlist-Merge-Reject Merge-Reject-61
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blockedon: 755703
Blockedon: -755703
Labels: -Merge-Reject-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 17 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e6352babb20388e7d1ea11f5d377222e3d3695

commit 02e6352babb20388e7d1ea11f5d377222e3d3695
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:35:45 2017

Record USB printers installed automatically.

USB printers are installed automatically if we are sure of the
configuration.  Log these printers with USB attributes and the fact
that they were configured automatically.

TBR=skau@chromium.org

(cherry picked from commit 1f7193d347a565c5e3f1e5eef810dab2c5e97402)

Bug:  740270 ,  725739 
Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681
Reviewed-on: https://chromium-review.googlesource.com/598691
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491800}
Reviewed-on: https://chromium-review.googlesource.com/619756
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#659}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/usb_printer_detector.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba04f33bacf03ed42f002ce3bfdf341b70f75e84

commit ba04f33bacf03ed42f002ce3bfdf341b70f75e84
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:57:47 2017

Record printer installation metrics for automatic and manual installs.

Record IPP make and model information, USB information, and chosen
PPD data for printers installed from the printer setup page.

TBR=skau@chromium.org

(cherry picked from commit 2027281ba9565edf3ed5dd745de6b734d5abc6ed)

Bug:  740270 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I08c34e54694de3eadf3647d16ff052f1ef848eb6
Reviewed-on: https://chromium-review.googlesource.com/600890
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494133}
Reviewed-on: https://chromium-review.googlesource.com/619852
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#663}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/ba04f33bacf03ed42f002ce3bfdf341b70f75e84/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment