New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740263 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Speed up symbolize_trace.py

Project Member Reported by erikc...@chromium.org, Jul 7 2017

Issue description

It takes 5min+ to symbolize traces right now. 
 
5 mins on macOS, right? etienneb@, what about Windows?

I'll check numbers on Android.
These numbers are dependent on the size of the trace itself. In this case, Etienne and I have been using the smallest trace with native heap profiling I was able to take on my laptop [close all tabs except for 1].

https://drive.google.com/a/chromium.org/file/d/0B0m63ZlVXb_nNFdvMGJpS0R6V1k/view?usp=sharing

Note that with Etienne's WIP breakpad symbolization, we're able to symbolize the same trace on all platforms.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd458915f1a65c631f3a8e09e9f625ed935b927

commit cbd458915f1a65c631f3a8e09e9f625ed935b927
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Jul 08 00:51:43 2017

Roll src/third_party/catapult/ 9a5b75ed3..256098db1 (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9a5b75ed3609..256098db1e09

$ git log 9a5b75ed3..256098db1 --date=short --no-merges --format='%ad %ae %s'
2017-07-07 benjhayden Reland Fix _GetSelectedTestPathsForDict in /list_tests handler.
2017-07-07 erikchen Use json.dumps instead of json.dump in symbolize_trace.py.
2017-07-07 benjhayden Clean up MERGED_FROM in histogram.py.
2017-07-07 mikecase Decrease iter_timeout for logcat_monitor by factor of 10.

Created with:
  roll-dep src/third_party/catapult
BUG=740263


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2137321803b52e544fd47074a13225e63faf5e7b
Reviewed-on: https://chromium-review.googlesource.com/564066
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485120}
[modify] https://crrev.com/cbd458915f1a65c631f3a8e09e9f625ed935b927/DEPS

Here are some results of a ChromeOS trace 8M using the Breakpad symbolization.
Symbols are already downloaded, but each symbols files need to be partially parsed (read first line) to detect the module.

The symbolization process is splitted in these phases:
  [*] Reading trace                    : 16 sec
  [*] Fetching / Reading symbols files : 3 sec
  [*] Symbolisation                    : 45 sec
  [*] Updating the trace               : 20 sec

The trace was symbolized on Windows 10 / Python 2.7.3 / Z840.
Here are some results of a Mac trace 56M using the Breakpad symbolization.
Symbols were not downloaded (cached).

The symbolization process is splitted in these phases:

  [*] Reading trace                    :  71 sec
  [*] Fetching / Reading symbols files :  0 sec
  [*] Symbolisation                    :  91 sec
  [*] Updating the trace               :  91 sec

The trace was symbolized on Windows 10 / Python 2.7.3 / Z840.

Sign in to add a comment