New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740253 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 214886



Sign in to add a comment

Configure Intel HDA power save mode through a udev rule

Project Member Reported by mka@chromium.org, Jul 7 2017

Issue description

This setting is currently handled by laptop-mode-tools (LMT), which we intend to replace ( Issue 214886 ).

The configuration is done through two sysfs attributes (/sys/module/snd_hda_intel/parameters/power_save and /sys/module/snd_hda_intel/parameters/power_save_controller).

LMT enables power save mode when running on battery and disables it on AC. Since CrOS devices commonly run on battery it is expected that audio power save mode has no significant impact for the user. To avoid unnecessary complexity Intel HDA power save mode will be enabled statically at boot time.
 

Comment 1 by mka@chromium.org, Jul 8 2017

Blocking: 214886
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d26c380134362e11a24558b71862f03c3e301833

commit d26c380134362e11a24558b71862f03c3e301833
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Jul 14 02:45:54 2017

laptop-mode-tools: Disable module for Intel HDA power management

Power save mode is now enabled by a udev rule

BUG= chromium:740253 ,  chromium:214886 
TEST=build for squawks (w/o dependent CL) and boot
  cd /sys/module/snd_hda_intel/parameters
  echo 42 > power_save
  echo N > power_save_controller
  disconnect power
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 42
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => N
CQ-DEPEND=CL:565448

Change-Id: Icbe6640a1974c563397e7a9b67076c0f5e3c1213
Reviewed-on: https://chromium-review.googlesource.com/565657
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/d26c380134362e11a24558b71862f03c3e301833/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r43.ebuild
[modify] https://crrev.com/d26c380134362e11a24558b71862f03c3e301833/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild
[add] https://crrev.com/d26c380134362e11a24558b71862f03c3e301833/app-laptop/laptop-mode-tools/files/0037-disable-intel-hda-power-management.patch

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/97274f52b628853c9f5290f84e965d0fd1d3391f

commit 97274f52b628853c9f5290f84e965d0fd1d3391f
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Jul 14 02:45:54 2017

power: Add udev rule to enable power save mode for Intel HDA

This setting was previously handled by laptop-mode-tools (LMT). LMT
enabled power save mode when the device runs on battery and disables it
when running on AC. The udev rule enables power save mode statically at
boot time, independently of the power source.

BUG= chromium:740253 ,  chromium:214886 
TEST=build and boot on squawks
  cat /sys/module/snd_hda_intel/parameters/power_save
    => 10
  cat /sys/module/snd_hda_intel/parameters/power_save_controller
    => Y
CQ-DEPEND=CL:565657

Change-Id: I86b83ab0cef1b8f3e12d7d0be45a07fb18326d01
Reviewed-on: https://chromium-review.googlesource.com/565448
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/97274f52b628853c9f5290f84e965d0fd1d3391f/power_manager/udev/optional/99-powerknobs.rules

Comment 4 by mka@chromium.org, Jul 14 2017

Status: Verified (was: Assigned)

Sign in to add a comment