WebRtcEventlogHostTests flaky |
|||||
Issue descriptionWebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest is flaky on all platforms, see the dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest It recently caused the Win10 bot to turn red: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/13692 I will disable the test for now. Assigning to aleloi@ because the first WebRTC Audio engineers I found are currently OOO. Please pass it along if you cannot investigate. Thank you! Failure output is inconsistent: [ RUN ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest c:\b\c\b\win\src\content\browser\webrtc\webrtc_eventlog_host_unittest.cc(78): error: Expected: peer_connection_id Which is: 1 To be equal to: std::get<0>(start_params) Which is: 2 c:\b\c\b\win\src\content\browser\webrtc\webrtc_eventlog_host_unittest.cc(78): error: Expected: peer_connection_id Which is: 2 To be equal to: std::get<0>(start_params) Which is: 1 [ FAILED ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest (6 ms) [ RUN ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest c:\b\c\b\win\src\content\browser\webrtc\webrtc_eventlog_host_unittest.cc(78): error: Expected: peer_connection_id Which is: 2 To be equal to: std::get<0>(start_params) Which is: 3 c:\b\c\b\win\src\content\browser\webrtc\webrtc_eventlog_host_unittest.cc(78): error: Expected: peer_connection_id Which is: 3 To be equal to: std::get<0>(start_params) Which is: 2 [ FAILED ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest (5 ms) [ RUN ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest ../../content/browser/webrtc/webrtc_eventlog_host_unittest.cc:78: Failure Expected: peer_connection_id Which is: 0 To be equal to: std::get<0>(start_params) Which is: 1 ../../content/browser/webrtc/webrtc_eventlog_host_unittest.cc:78: Failure Expected: peer_connection_id Which is: 1 To be equal to: std::get<0>(start_params) Which is: 0 ../../content/browser/webrtc/webrtc_eventlog_host_unittest.cc:78: Failure Expected: peer_connection_id Which is: 3 To be equal to: std::get<0>(start_params) Which is: 4 ../../content/browser/webrtc/webrtc_eventlog_host_unittest.cc:78: Failure Expected: peer_connection_id Which is: 4 To be equal to: std::get<0>(start_params) Which is: 3 [ FAILED ] WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest (5 ms)
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f84f0baa01bc5b6f41ea428f1a465a05763c4ea1 commit f84f0baa01bc5b6f41ea428f1a465a05763c4ea1 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jul 07 22:46:44 2017 Disable WebRtcEventlogHostTest.ExceedMaxPeerConnectionsTest (flaky). TBR=guidou@chromium.org Bug: 740251 Change-Id: I8bd65c5fdf55437778ee21ed4f98b74a60c11589 Reviewed-on: https://chromium-review.googlesource.com/563774 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485077} [modify] https://crrev.com/f84f0baa01bc5b6f41ea428f1a465a05763c4ea1/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
,
Jul 31 2017
[+WebRTC owners] Any plans to fix these tests? Looks like another WebRtcEventlogHostTest is flaky as well (WebRtcEventlogHostTest.TwoPeerConnectionsTeststep_metadata).
,
Jul 31 2017
,
Jul 31 2017
The dupe was TwoPeerConnectionsTest, not ExceedMaxPeerConnectionsTest. If you dupe, retitle too, please.
,
Jul 31 2017
,
Jul 31 2017
ivoc@: are you aware of any reason why these WebRtcEventlogHostTest suddenly started to flake?
,
Jul 31 2017
,
Jul 31 2017
hbos@: Is it possible the the recent work on the RTP Media API can cause this?
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57781f843c7f278b80f9b7dc1403680a9eac939a commit 57781f843c7f278b80f9b7dc1403680a9eac939a Author: Ivo Creusen <ivoc@chromium.org> Date: Wed Aug 09 09:26:24 2017 Make WebRtcEventlogHostTest.* non-flaky. The result of the tests was dependent on the order of thread scheduling, which led to flakiness. The disabled tests are reenabled. Bug: 740251 , 750708 Change-Id: I2bdc617c4ef674e678b2489e24653679963d58fe Reviewed-on: https://chromium-review.googlesource.com/606247 Commit-Queue: Ivo Creusen <ivoc@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#492918} [modify] https://crrev.com/57781f843c7f278b80f9b7dc1403680a9eac939a/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
,
Aug 9 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bsep@chromium.org
, Jul 7 2017Components: -Blink>WebRTC>Audio Blink>WebRTC
Owner: guidou@chromium.org