New issue
Advanced search Search tips

Issue 740249 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 740247



Sign in to add a comment

Add security_style to SecurityStyleExplanation

Project Member Reported by lgar...@chromium.org, Jul 7 2017

Issue description

This is needed for Issue 740247.

Conceptually, the security style belongs into the explanation itself anyhow.
We already do that in the DevTools protocol: https://chromium.googlesource.com/chromium/src/+/ed0d20f7c347cc2ec55621918941556e141d8341/third_party/WebKit/Source/core/inspector/browser_protocol.json#1061

The straightforward type to use would be blink::WebSecurityStyle.
 
Labels: Hotlist-GoodFirstBug

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Hi Igar, 

I found two files where I can potentially add blink::WebSecurityStyle security_style: [1] and [2]. I saw that [2] includes [1]. Where do you think the type should be added?

[1] //src/content/public/browser/security_style_explanations.h
[2] //src/content/public/browser/security_style_explanation.h

Thanks!

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment