New issue
Advanced search Search tips

Issue 740248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 7 2017

Issue description

"WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJXZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5WZXJpZnlDYW52YXNDYXB0dXJlT2Zmc2NyZWVuQ2FudmFzQ29tbWl0RnJhbWVzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 695452 .
 

Comment 1 by bsep@chromium.org, Jul 7 2017

Components: Blink>WebRTC
Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)
I am disabling the test. Assigning to file OWNER.
Cc: mcasas@chromium.org
Components: Blink>MediaStream>CaptureFromElement
Labels: -Pri-1 Pri-2
Owner: emir...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37b3e440b33eaabbc629da0e8ac087754c41b73b

commit 37b3e440b33eaabbc629da0e8ac087754c41b73b
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Jul 08 00:29:19 2017

Disable WebRTC test VerifyCanvasCaptureOffscreenCanvasCommitFrames.

WebRtcCaptureFromElementBrowserTest.
VerifyCanvasCaptureOffscreenCanvasCommitFrames was reported as flaky.
Looks like it's timing out.

TBR=mcasas@chromium.org

Bug:  740248 
Change-Id: If8ab0a57e5870dfbc8945d0cb8423d6957767e0c
Reviewed-on: https://chromium-review.googlesource.com/564179
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485114}
[modify] https://crrev.com/37b3e440b33eaabbc629da0e8ac087754c41b73b/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc

Comment 4 by bsep@chromium.org, Jul 8 2017

Labels: -Sheriff-Chromium
Removing from sheriff queue.
Status: Started (was: Assigned)
I ran this test ~300 times on linux but couldn't get any failures, see below. There is nothing linux specific in canvas capture code, so I am not sure if it was capture related to begin with. It can be a canvas render issue that has been addressed. So I am going to reenable the tests and keep an eye on bots.
testruns.txt
424 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb9ca3902e665622ac74720de429c1893207885

commit cbb9ca3902e665622ac74720de429c1893207885
Author: Emircan Uysaler <emircan@chromium.org>
Date: Fri Jan 12 17:25:42 2018

Reenable test VerifyCanvasCaptureOffscreenCanvasCommitFrames

I cannot reproduce the flakiness in local test runs any more, see below bug.
Reenabling test that was marked as flaky on linux.

Bug:  740248 
Change-Id: I0bf870b9c2c70b0df3d53e9c1fc70d27d46e0690
Reviewed-on: https://chromium-review.googlesource.com/862615
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528983}
[modify] https://crrev.com/cbb9ca3902e665622ac74720de429c1893207885/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc

Sign in to add a comment