Add items to the side menu
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c67190f5c3e22fb92a591fb5ebed6972d6111a5 commit 4c67190f5c3e22fb92a591fb5ebed6972d6111a5 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Jul 10 20:56:29 2017 [CRD iOS] Implement SideMenuItem Implement SideMenuItem and SideMenuItemsProvider in Chromium to define the list of items to be shown on the internal build's side menu. Bug: 740240 Change-Id: I8577024a67b741453b9dbc757f02bede0da6927f Reviewed-on: https://chromium-review.googlesource.com/563772 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#485377} [modify] https://crrev.com/4c67190f5c3e22fb92a591fb5ebed6972d6111a5/remoting/ios/app/BUILD.gn [add] https://crrev.com/4c67190f5c3e22fb92a591fb5ebed6972d6111a5/remoting/ios/app/side_menu_items.h [add] https://crrev.com/4c67190f5c3e22fb92a591fb5ebed6972d6111a5/remoting/ios/app/side_menu_items.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7db8ecb0eaf46dcebd6db8208746dcc3897ce301 commit 7db8ecb0eaf46dcebd6db8208746dcc3897ce301 Author: yuweih <yuweih@google.com> Date: Mon Jul 10 22:50:33 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468 commit ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Jul 11 23:59:59 2017 [CRD iOS] Add icons for side menu items This CL adds icons for the send feedback and help items in the side menu. One more internal CL is needed to make the side menu properly tint the icons. Bug: 740240 Change-Id: I96fe2d2139f36056a925af75752df0db5f41354c Reviewed-on: https://chromium-review.googlesource.com/565420 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#485732} [modify] https://crrev.com/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468/remoting/ios/app/remoting_theme.h [modify] https://crrev.com/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468/remoting/ios/app/remoting_theme.mm [modify] https://crrev.com/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468/remoting/ios/app/resources/BUILD.gn [modify] https://crrev.com/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468/remoting/ios/app/side_menu_items.mm [modify] https://crrev.com/ef20aa5f8cf3c17ba11f26cbe16b6fb52c322468/third_party/material_design_icons/BUILD.gn
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/46315a23dd8aa0ce6d2a9a0abdbbd01c882aeeae commit 46315a23dd8aa0ce6d2a9a0abdbbd01c882aeeae Author: yuweih <yuweih@google.com> Date: Wed Jul 12 01:53:33 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30aaa618c205b10d7de39475db1c404144db1e34 commit 30aaa618c205b10d7de39475db1c404144db1e34 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Jul 17 21:25:57 2017 [CRD iOS] Make the side menu help button work This CL: * Implements a WebViewController that automatically adds a close button to the nav bar when it's the first VC in the nav stack, and allow overriding the right nav button. * Adds the Credits button to the help center VC. * Makes the side menu's help button work. Bug: 740240 Change-Id: I28436ada3ea1a9e588be0cedfc2e5b874c82d4d9 Reviewed-on: https://chromium-review.googlesource.com/572602 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#487248} [modify] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/BUILD.gn [modify] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/app_delegate.h [modify] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/app_delegate.mm [modify] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/side_menu_items.mm [add] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/web_view_controller.h [add] https://crrev.com/30aaa618c205b10d7de39475db1c404144db1e34/remoting/ios/app/web_view_controller.mm
Verified in 63.0.3220.0
Comment 1 by bugdroid1@chromium.org
, Jul 10 2017