PushPullFIFOSmokeTest tests take too long to run |
|||
Issue descriptionIt appears that these tests are parameterized to block for a configurable amount of seconds. Unfortunately, this more than doubles the runtime of a release + DCHECK build of webkit_unit_tests. Can we: - Make the tests faster? Is it a requirement that they run for N seconds? - Move them to a different binary (I'd argue they're not really unit tests, but more along the line of integration or smoke tests, per their name) - Something else?
,
Jul 19 2017
Hmm. I thought Hongchan had made some changes to reduce the runtime. hongchan@ can you take a look?
,
Jul 19 2017
dcheng@ Can you elaborate on the second option? (Move them to a different binary) If that doesn't work out, I'll try to reduce of the smoke test workload.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d62e0e68cc41b56b63677af68ad477033469a7e6 commit d62e0e68cc41b56b63677af68ad477033469a7e6 Author: Hongchan Choi <hongchan@chromium.org> Date: Fri Jul 28 19:14:01 2017 Reducing test duration of PushPullFIFOMultithreadTest from 20s to 5s This test was slowing down the unit tests execution on try bots and was asked to reduce the test duration. Bug: 740235 Change-Id: I12969afa8d22be7516ed5e44c375480c76abf68c Reviewed-on: https://chromium-review.googlesource.com/592109 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#490484} [modify] https://crrev.com/d62e0e68cc41b56b63677af68ad477033469a7e6/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
,
Jul 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dcheng@chromium.org
, Jul 19 2017