New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740232 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chromium SDK libc++ __cxxabi_config.h symlink is broken

Project Member Reported by bcf@chromium.org, Jul 7 2017

Issue description

Tested on version 2017.07.06.155330

% ls -l usr/armv7a-cros-linux-gnueabi/usr/include/c++/v1/__cxxabi_config.h
lrwxrwxrwx 1 bcf eng 41 Jul  6 21:32 usr/armv7a-cros-linux-gnueabi/usr/include/c++/v1/__cxxabi_config.h -> ../../libcxxabi/include/__cxxabi_config.h

It should be

usr/armv7a-cros-linux-gnueabi/usr/include/c++/v1/__cxxabi_config.h -> ../../libcxxabi/__cxxabi_config.h
 
Status: Started (was: Untriaged)
It is easier to move the actual header file from  
/usr/armv7a-cros-linux-gnueabi/usr/include/libcxxabi/__cxxabi_config.h
/usr/armv7a-cros-linux-gnueabi/usr/include/libcxxabi/cxxabi.h

to 

/usr/armv7a-cros-linux-gnueabi/usr/include/libcxxabi/include/__cxxabi_config.h
/usr/armv7a-cros-linux-gnueabi/usr/include/libcxxabi/include/cxxabi.h


Would this do the job?

Comment 3 by bcf@chromium.org, Jul 7 2017

Which configuration is the intended one from upstream? We should probably follow that.
upstream copy the header file over instead of using symbolic link. We probably can do that too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e9be242257eb2fe693ce4306a8a7280c7ceac364

commit e9be242257eb2fe693ce4306a8a7280c7ceac364
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jul 12 21:24:38 2017

libcxx: remove a symbolic link in the source code.

Android souce tree adds a symbolic link of __cxxabi_config.h
from libcxxabi to libcxx. This causes libcxx install a symbolic
link of __cxxabi_config.h which points to a wrong location.
We do not need that symbolic link and this CL removes that.

BUG= chromium:740232 
TEST=sudo emerge cross-x86_64-cros-linux-gnu/libcxx
     /usr/x86_64-cros-linux-gnu/usr/include/c++/v1/__cxxabi_config.h
     is a real file instead of a symbolic link.

Change-Id: I1b0a727c778463a1100f24a9ee19df63b5039190
Reviewed-on: https://chromium-review.googlesource.com/567521
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/e9be242257eb2fe693ce4306a8a7280c7ceac364/sys-libs/libcxx/libcxx-4.0.0-r5.ebuild

Status: Verified (was: Started)

Sign in to add a comment