New issue
Advanced search Search tips

Issue 740230 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Fix GCC Bisection driver issues with exit code and non .o files

Project Member Reported by manojgupta@chromium.org, Jul 7 2017

Issue description

Current bisect driver does not return exit value correctly.
Also, any filename other than those ending in .o are not handled.

Both of these are required when bisecting Linux kernel.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/fcf26b3b89a7893c7430841ab153e1a58d657c12

commit fcf26b3b89a7893c7430841ab153e1a58d657c12
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Jul 11 23:49:35 2017

Fix compiler bisection tests nowrapper script.

SAVE_DIR was being overwritten. Inside the condition,
SAVE_DIR is not needed. Just use DIR directly.

BUG= chromium:740230 
TEST= ./full_bisect_test/run-test-nowrapper.sh works.

Change-Id: Ic35d3039f6fd31f2a5f3a0d4812568eaceda4742
Reviewed-on: https://chromium-review.googlesource.com/567364
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/fcf26b3b89a7893c7430841ab153e1a58d657c12/binary_search_tool/full_bisect_test/run-test-nowrapper.sh

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/faad71b7564137fd1f05f99099daee5d27d2775d

commit faad71b7564137fd1f05f99099daee5d27d2775d
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jul 12 23:19:23 2017

GCC: Update bisection driver wrapper.

Cache more filenames besides ".o".
Return correct compiler exit code in bisection.
Also uprev gcc ebuild to make this change effective.

BUG= chromium:740230 
TEST=Files ending in non .o e.g. .ko or .os are cached.
TEST=Correct exit code is returned in object bisection.

Change-Id: I8498ff51dca230023bbf1a2c91ba6977084d0e94
Reviewed-on: https://chromium-review.googlesource.com/563710
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/faad71b7564137fd1f05f99099daee5d27d2775d/sys-devel/gcc/gcc-4.9.2-r160.ebuild
[modify] https://crrev.com/faad71b7564137fd1f05f99099daee5d27d2775d/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[modify] https://crrev.com/faad71b7564137fd1f05f99099daee5d27d2775d/sys-devel/gcc/files/bisect_driver.py

Status: Verified (was: Untriaged)

Sign in to add a comment