New issue
Advanced search Search tips

Issue 740227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

autoninja doesn't work with the '-t' ninja flag

Project Member Reported by sebmarchand@chromium.org, Jul 7 2017

Issue description

autoninja is incompatible with the '-t' ninja flag, e.g.:

ninja -C ..\out\Debug -t clean
ninja.exe -C ..\out\Debug -t clean -l 48
clean: invalid option -- `-l'
usage: ninja -t clean [options] [targets]

options:
  -g     also clean files marked as ninja generator output
  -r     interpret targets as a list of rules to clean instead



 
Status: Assigned (was: Untriaged)
I'll do some testing to figure out when I should/shouldn't add the -l flag.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/1f767e1797d8a7fe53f207a878b614cdba9ee7f6

commit 1f767e1797d8a7fe53f207a878b614cdba9ee7f6
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Fri Jul 07 22:25:42 2017

Fix autoninja.py for ninja -t compatibility

The -t tools in ninja fail if -j or -l are specified. So, autoninja.py
needs to watch for -t and omit -j and -l if it is noticed.

R=sebmarchand@chromium.org
BUG= 740227 

Change-Id: I1418193daeab154178d15be60ab09551bacaf3af
Reviewed-on: https://chromium-review.googlesource.com/563775
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

[modify] https://crrev.com/1f767e1797d8a7fe53f207a878b614cdba9ee7f6/autoninja.py

Status: Fixed (was: Assigned)

Sign in to add a comment