New issue
Advanced search Search tips

Issue 740216 link

Starred by 5 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

hterm: add a window-close-behavior option

Project Member Reported by vapier@chromium.org, Jul 7 2017

Issue description

currently if you close a window (either on purpose or inadvertently), we kill the session immediately.  we should add an option so users can control this, and by default we throw up a prompt catch it.

it'll be an enum:
- prompt: user will be shown a prompt and they can decide what to do
- always-close: user will not be prompted, and the window will be closed

i'm not going with a bool in case we want to add more options here.  like "never-close" (although it'd require some thought as to how we'd actually let the user close) and "always-prompt" (and the default "prompt" would include an option to switch to "never ask again").
 

Comment 1 by vapier@chromium.org, Sep 15 2017

 Issue 765534  has been merged into this issue.
For the back button case ( Issue 765534 ), I would argue that no option is necessary. The back button on a terminal window should always be a no-op.

Comment 3 by vapier@chromium.org, Sep 15 2017

in the case of a standalone Secure Shell window, it's reasonable to always make that silently ignored.  but when you talk about Secure Shell in a tab, or hterm embedded in a website, it's a very different conversation.  especially when you consider that Secure Shell handles ssh:// URIs.  if i'm in a tab, and i click the ssh:// URI, and Secure Shell loads (in the tab), i think it's reasonable for users to expect back events to go actually go back.

another enum to throw into the mix i guess :).

Comment 4 by vapier@chromium.org, Nov 20 2017

related discussion:
https://github.com/rpwoodbu/mosh-chrome/issues/5

Comment 5 by vapier@chromium.org, Jan 15 2018

 Issue 802093  has been merged into this issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 16

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment