Tab crashes when adding element with long color property
Reported by
lysio...@gmail.com,
Jul 7 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: 1. Open color-crash.html What is the expected behavior? No crash What went wrong? Tab crashes Did this work before? N/A Chrome version: 59.0.3071.115 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jul 7 2017
When you set: 1. i = 0x4000 (line 10) then "Uncaught RangeError: Invalid string length at color-crash.html:12" can be seen. 2. i = 0x100 (line 10) then there is no problem at all.
,
Jul 7 2017
CSS parsing issue?
,
Jul 7 2017
Able to reproduce this issue on Win7.
,
Jul 10 2017
Able to reproduce the issue on Windows 7,Mac 10.12.5 & Ubuntu 14.04 using latest chrome stable#59.0.3071.115 & Canary#61.0.3152.0 as per the provided html in comment#0. Tab crashed upon opening the html file. This is non regression issue observed from M45,hence marking it as Untriaged to get more inputs from dev. Please find the attached screenshot for reference. Thank you..!!
,
Jul 10 2017
Seems like this is hitting an allocation limit: [1:1:0710/110346.115988:1729119947146:FATAL:PartitionAllocator.h(37)] Check failed: count <= MaxElementCountInBackingStore<T>() (156590080 vs. 89478314) #0 0x00000165d257 base::debug::StackTrace::StackTrace() #1 0x0000016705dd logging::LogMessage::~LogMessage() #2 0x000002918a2c WTF::PartitionAllocator::QuantizedSize<>() #3 0x0000029540d1 WTF::Vector<>::ReserveCapacity() #4 0x000002954052 WTF::Vector<>::AppendSlowCase<>() #5 0x0000029521f1 blink::CSSTokenizer::CSSTokenizer() #6 0x000002938814 blink::CSSParserImpl::ParseValue() #7 0x000002933a51 blink::CSSParser::ParseValue() #8 0x000002924407 blink::MutableStylePropertySet::SetProperty() #9 0x00000291291a blink::AbstractPropertySetCSSStyleDeclaration::SetPropertyInternal() #10 0x000003a3111b blink::V8CSSStyleDeclaration::namedPropertySetterCustom() #11 0x0000026625ba blink::V8CSSStyleDeclaration::namedPropertySetterCallback() Adding timloh since AFAIK he is still the CSSTokenizer expert.
,
Jul 11 2017
Is there any reason to handle this gracefully? What's the real-world use case for setting a color or whatnot to a string of 200 million characters?
,
Jul 11 2017
Since that bug is a public one what about prevent trolling by script-kiddies? Anyway this bug could be used by anyone to do anything malicious to any Chrome/Chromium user.
,
Jul 11 2017
What in particular does "anything malicious" entail? Being able to OOM the renderer by executing JS doesn't seem productive to anyone.
,
Jul 11 2017
Well honestly I don't know how this could be used by non-trolls. I filled a bug before someone smarter than I start using it widely with a more productive case than I showed here:)
,
Jul 12 2017
I don't think this is something we're too worried about, but thanks for the report, lysiol41! Marking as WontFix accordingly.
,
Jul 12 2017
Thanks:) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 Deleted