New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add timeout to webapk_update_data_fetcher.cc

Project Member Reported by pkotw...@chromium.org, Jul 7 2017

Issue description

As a result of https://codereview.chromium.org/2963473003 WebApkUpdateManager#onWebManifestForInitialUrlNotWebApkCompatible() is no longer called.

This prevents pages which are no longer WebAPK-able from updating their ShellAPK

 
We should add a time out to WebApkUpdateDataFetcher
Labels: -Pri-3 Pri-1
We need this for M62. Otherwise, we risk users not getting ShellAPK updates.

I think that can put the timeout in WebApkUpdateManager.java instead of webapk_update_data_fetcher.cc (and clean up the code a bit)

Comment 3 by hanxi@chromium.org, Jul 25 2017

Owner: ranj@chromium.org
Status: Assigned (was: Untriaged)
Sorry, I linked to the incorrect CL. The correct CL is https://codereview.chromium.org/2942513002
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7

commit 38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7
Author: Ran Ji <ranj@chromium.org>
Date: Sun Aug 13 04:35:38 2017

Add timeout for webapk update

This is a followup for cl https://codereview.chromium.org/2942513002.
After that cl, onWebManifestForInitialUrlNotWebApkCompatible is no
longer called, we need a way to tell Webapk update failure if no
service worker available.

Bug:  740179 
Change-Id: I17362007585283a3c4671178e0ba141f3fd38b46
Reviewed-on: https://chromium-review.googlesource.com/591917
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493990}
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/38ebb056c50bc5b372d9fded5d6fdad3c2bac6a7/chrome/browser/android/webapk/webapk_update_data_fetcher.h

Comment 6 by ranj@chromium.org, Aug 13 2017

Status: Fixed (was: Assigned)

Sign in to add a comment