[WPT Export] Implement pagination in WPTGitHub.all_pull_requests |
||||
Issue descriptionCurrently we only fetch the 100 most recent pull requests. We should fetch all of them.
,
Jul 11 2017
,
Jul 24 2017
,
Jul 25 2017
By the way, do we also need pagination for WPTGitHub.in_flight_pull_requests? As a side note, there are currently 29 open PRs with the chromium-export label, and the default item number per page is 100 for search results (30 for other GitHub endpoints).
,
Jul 26 2017
It looks like there actually is no longer anything using in_flight_pull_requests, so feel free to delete that method in your CL, or I can create a separate CL for that.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9295083665c81b8ab3ad300d59f4437f71cb5313 commit 9295083665c81b8ab3ad300d59f4437f71cb5313 Author: Robert Ma <robertma@chromium.org> Date: Wed Aug 02 19:48:18 2017 [WPT Export] Implement pagination in WPTGitHub.all_pull_requests Bug: 740175 Change-Id: Id391cbd1e60b34a5ef4cc4ac988f04d3a343e224 Reviewed-on: https://chromium-review.googlesource.com/587270 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491472} [modify] https://crrev.com/9295083665c81b8ab3ad300d59f4437f71cb5313/third_party/WebKit/Tools/Scripts/webkitpy/common/net/web_mock.py [modify] https://crrev.com/9295083665c81b8ab3ad300d59f4437f71cb5313/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py [modify] https://crrev.com/9295083665c81b8ab3ad300d59f4437f71cb5313/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
,
Aug 3 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jeffcarp@chromium.org
, Jul 7 2017