Query enable_instant_source_buffer_gc directly, rather than passing it via prefs |
|||
Issue descriptionThis bug is for tracking the following TODO: content/browser/renderer_host/render_view_host_impl.cc: RenderViewHostImpl::ComputeWebkitPrefs: // TODO(servolk, asvitkine): Query the value directly when it is available in // the renderer process. See https://crbug.com/681160 . prefs.enable_instant_source_buffer_gc = variations::GetVariationParamByFeatureAsBool( media::kMemoryPressureBasedSourceBufferGC, "enable_instant_source_buffer_gc", false); Addressing this TODO might help remove //content -> //components/variations/variations_associated_data.h dependency.
,
Jul 7 2017
Is this still blocked on issue 681160 (which is marked as fixed)?
,
Jul 7 2017
Thanks for bringing this to my attention, you are right, now that 681160 has been fixed, we can get rid of the TODOs and get the flag value directly in the renderer process: https://chromium-review.googlesource.com/c/563865/
,
Jul 8 2017
Thanks! BTW - I should note that this bug is a follow-up to the comments in https://codereview.chromium.org/2946113002/diff/200001/content/DEPS#newcode28
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b1846e823506d43cd315f7c41d0f777a4c26ff6 commit 8b1846e823506d43cd315f7c41d0f777a4c26ff6 Author: Sergey Volk <servolk@google.com> Date: Mon Jul 10 19:37:04 2017 Get enable_instant_source_buffer_gc flag directly in the renderer Previously Finch trial flags were not properly propagated from the browser process to renderers and so we had to pass the flag value explicitly via IPC from browser to renderers. But Finch flag propagation has been fixed and now we can remove the explicit IPC and get the flag value from base::GetFieldTrialParamByFeatureAsBool. Bug: 740174 Change-Id: Iba3af2626362ba3cec6798794934edd69a873f46 Reviewed-on: https://chromium-review.googlesource.com/563865 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#485348} [modify] https://crrev.com/8b1846e823506d43cd315f7c41d0f777a4c26ff6/content/browser/renderer_host/render_view_host_impl.cc [modify] https://crrev.com/8b1846e823506d43cd315f7c41d0f777a4c26ff6/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/8b1846e823506d43cd315f7c41d0f777a4c26ff6/content/public/common/web_preferences.cc [modify] https://crrev.com/8b1846e823506d43cd315f7c41d0f777a4c26ff6/content/public/common/web_preferences.h [modify] https://crrev.com/8b1846e823506d43cd315f7c41d0f777a4c26ff6/content/renderer/media/media_factory.cc
,
Jul 10 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lukasza@chromium.org
, Jul 7 2017