VR: With skip VR entry screens on Choreographer callback is doubled up. |
|||||||
Issue descriptionWe pause the vsync estimator in onstop, and start it in onresume, so if we get paused and resumed we create a second choreographer loop. We should just move the esimator pause to onpause.
,
Jul 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ce01d74264f25346da3b01f9fc3accaa91a1dd7 commit 1ce01d74264f25346da3b01f9fc3accaa91a1dd7 Author: Michael Thiessen <mthiesse@chromium.org> Date: Sat Jul 08 02:10:15 2017 VR: Fix double-queueing of Choreographer callbacks when skipping VR entry screens Moves pausing of the vsync estimator into onPause rather than onStop. Bug: 740161 Change-Id: I4a8c3b9ecfd60bc43ed3499761cc6b0391f47082 Reviewed-on: https://chromium-review.googlesource.com/563858 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#485129} [modify] https://crrev.com/1ce01d74264f25346da3b01f9fc3accaa91a1dd7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 8 2017
,
Jul 10 2017
I'm still seeing this, just less frequently. Stdout: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_VR_Tests%2F9344%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_vr_apk-nonddready-cardboard-current-lollipop_on_Android%2F0%2Fstdout Failed build: https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests/builds/9344
,
Jul 12 2017
Different issue, but the fix is here: https://chromium-review.googlesource.com/c/568458/
,
Jul 12 2017
,
Mar 1 2018
,
Jul 4
,
Aug 29
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mthiesse@chromium.org
, Jul 7 2017