New issue
Advanced search Search tips

Issue 740161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR: With skip VR entry screens on Choreographer callback is doubled up.

Project Member Reported by mthiesse@chromium.org, Jul 7 2017

Issue description

We pause the vsync estimator in onstop, and start it in onresume, so if we get paused and resumed we create a second choreographer loop.

We should just move the esimator pause to onpause.
 
Labels: Proj-VR
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce01d74264f25346da3b01f9fc3accaa91a1dd7

commit 1ce01d74264f25346da3b01f9fc3accaa91a1dd7
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Sat Jul 08 02:10:15 2017

VR: Fix double-queueing of Choreographer callbacks when skipping VR entry screens

Moves pausing of the vsync estimator into onPause rather than onStop.

Bug:  740161 
Change-Id: I4a8c3b9ecfd60bc43ed3499761cc6b0391f47082
Reviewed-on: https://chromium-review.googlesource.com/563858
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485129}
[modify] https://crrev.com/1ce01d74264f25346da3b01f9fc3accaa91a1dd7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Started)
Different issue, but the fix is here: https://chromium-review.googlesource.com/c/568458/
Status: Fixed (was: Assigned)
Labels: VR-Caught-By-Test
Components: Internals>XR
Labels: -VR-Caught-By-Test XR-Caught-By-Test

Sign in to add a comment