Issue metadata
Sign in to add a comment
|
CQ: Provide a tag when unvoting on Gerrit label |
||||||||||||||||||||
Issue descriptionEven after clicking 'Show comments only', the messages section is spammed by all kinds of irrelevant auto-generated comments such as 'Commit-Queue+1'. See attached image for an example where the single real comment is spammed with 3 auto-generated comments. And as an aside, 'Show comments only'/'Expand all' should really be the default.
,
Jul 7 2017
The API endpoint that Commit-Bot uses to clean up other users' Commit-Queue votes when it processes them doesn't support the tag feature that Gerrit depends on to identify non-comment messages.
,
Jul 7 2017
I dug into the code for Commit-Bot. I see that it doesn't actually delete votes this way, it uses a different endpoint that *does* support tag. I don't see Commit-Bot providing a tag, however: https://cs.corp.google.com/chromium_infra_internal/infra_internal/services/cq/pending_manager/gerrit.py?l=170-173
,
Jul 7 2017
,
Jul 10 2017
My summary change seems to have been reverted by the issue move, see issue monorail:2711.
,
Jul 10 2017
,
Jul 10 2017
,
Jul 10 2017
https://chrome-internal-review.googlesource.com/409069
,
Jul 10 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/910ea7e96ca0ea188f33aaf92ff99d70bd8a1df3 commit 910ea7e96ca0ea188f33aaf92ff99d70bd8a1df3 Author: Aaron Gable <agable@chromium.org> Date: Mon Jul 10 20:07:29 2017
,
Jul 10 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, Jun 29 2017