New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740149 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 690042



Sign in to add a comment

8.4% regression in system_health.memory_mobile at 479757:479813

Project Member Reported by primiano@chromium.org, Jul 7 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=740149

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ff5dc42abf820cc337ced2f4a0dfaaca5df6cdd759f5d97361b5ce573732dfd9


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Cc: qin...@chromium.org
Owner: qin...@chromium.org

=== Auto-CCing suspected CL author qinmin@chromium.org ===

Hi qinmin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Min Qin
  Commit : 7edfb30614c81091fa1e5880be3029b7a7ca9ed2
  Date   : Thu Jun 15 18:14:28 2017
  Subject: Check if a DownloadHistoryItemWrapper is null

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_news/load_news_irctc
  Change       : 0.93% | 14389248.0 -> 14254762.6667

Revision             Result                   N
chromium@479756      14389248 +- 83893.0      6      good
chromium@479757      7740075 +- 147986        6      bad       <--
chromium@479758      12635477 +- 5465579      6      bad
chromium@479760      13750443 +- 76140.7      6      bad
chromium@479764      13770069 +- 103729       6      bad
chromium@479771      13946197 +- 94059.5      6      bad
chromium@479785      14103893 +- 134161       6      bad
chromium@479813      14254763 +- 70390.8      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974710648686227152


For feedback, file a bug with component Speed>Bisection
Status: Assigned (was: Untriaged)
Take a look at this doc: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

which will help with debugging. Although, I'm not convinced your CL could've caused this change. Please let us know what you think.
Cc: -qin...@chromium.org -primiano@chromium.org
Owner: primiano@chromium.org
I don't think this is related to my CL. And Download home is not available for webview, so if the bot is android-webview-nexus6, i don't feel my CL will cause such issues.
Cc: perezju@chromium.org hjd@chromium.org
+hjd, perezju: looks like the bisect runs were not independent in #3.
Blockedon: 690042
Inspecting over the bisect results it looks like there is no regression but, yeah, java_heap is being wonky.
Status: WontFix (was: Assigned)
WontFixing because this went back down and we have other bugs about investigating reproducibility.

Sign in to add a comment