aria-haspopup used to be a boolean, but now it has several values that can be exposed, like "dialog" or "tree". Note: we should implement this as a sparse attribute!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb commit fee38fe5d637a5f0ea3d06708ec12a9981fce6bb Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Jul 19 06:38:43 2017 Implement AccessibleNode.hasPopUp for Accessibility Object Model phase 1 This is the last AOM phase 1 property! I missed it earlier because it used to be a boolean attribute but in ARIA 1.1 it was changed to a string. This change just hooks up the AOM portion, but I filed bug 740137 to track plumbing through the string value of haspopup rahter than treating it as a boolean elsewhere. BUG= 680345 , 740137 Review-Url: https://codereview.chromium.org/2973973002 Cr-Commit-Position: refs/heads/master@{#487773} [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.cpp [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.h [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/core/dom/AccessibleNode.idl [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/fee38fe5d637a5f0ea3d06708ec12a9981fce6bb/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
whats the status of this?
Dear all, I've updated patch as below. https://chromium-review.googlesource.com/c/chromium/src/+/896672
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbd46ada2fc3421eae7a5d621b2524ac635c9baa commit dbd46ada2fc3421eae7a5d621b2524ac635c9baa Author: DongJun Kim <djmix.kim@samsung.com> Date: Thu May 03 23:57:39 2018 Refactoring aria-haspopup This patch is for refactoring aria-haspopup following latest spec. Changed the value type of aria-haspopup from boolean to token in ARIA 1.1 [1]. Also, the implicit value for role combobox was changed from true to listbox. Supported values are : - true - false (default) - menu - listbox - tree - grid - dialog We expose both of "HASPOPUP" state and "haspopup:" values for backwards compatibility. [1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes Bug: 740137 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib4988026c8728f64dfe4b30e842ef68620f093a5 Reviewed-on: https://chromium-review.googlesource.com/896672 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#555911} [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/chrome/common/extensions/api/automation.idl [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/browser/accessibility/browser_accessibility_android.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/browser/accessibility/browser_accessibility_cocoa.mm [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/renderer/accessibility/blink_ax_enum_conversion.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/renderer/accessibility/blink_ax_enum_conversion.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/renderer/accessibility/blink_ax_tree_source.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/shell/test_runner/web_ax_object_proxy.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/shell/test_runner/web_ax_object_proxy.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-autocomplete-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-autocomplete.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-button-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-button-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-button.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-combobox-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-combobox-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-combobox.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-expanded-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-expanded-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-expanded.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-haspopup-expected-android.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-haspopup-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-haspopup-expected-mac.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-haspopup-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-haspopup.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-illegal-val-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-illegal-val-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-illegal-val.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-readonly-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-readonly-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria-readonly.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria1.1-combobox-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria1.1-combobox-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/aria/aria1.1-combobox.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/action-verbs-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/action-verbs-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/action-verbs.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-datetime-local-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-datetime-local.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-list-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-list-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-list.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-month-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-month.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-suggestions-source-element-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-suggestions-source-element-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-suggestions-source-element.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-week-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-week-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/input-week.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/modal-dialog-closed.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/select-expected-blink.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/select-expected-win.txt [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/content/test/data/accessibility/html/select.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/WebKit/LayoutTests/accessibility/aria-activedescendant.html [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/public/web/web_ax_enums.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/public/web/web_ax_object.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/core/html/forms/picker_indicator_element.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/core/inspector/browser_protocol.pdl [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_enums.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_enums.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_layout_object.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_object.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/ax_object.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/blink/renderer/modules/exported/web_ax_object.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/third_party/closure_compiler/externs/automation.js [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_enum_util.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_enum_util.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_enums.mojom [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_node_data.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_node_data.h [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/ax_node_position_unittest.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/platform/ax_platform_node_auralinux.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/views/controls/button/menu_button.cc [modify] https://crrev.com/dbd46ada2fc3421eae7a5d621b2524ac635c9baa/ui/views/controls/menu/menu_item_view.cc
I believe this should be marked fixed.
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017